Parse attributes before annotations

Postponed on 📌 Add a fallback classloader that can handle missing traits Active

📌 Add a fallback classloader that can handle missing traits Active is in, so this is unblocked.

MR is ready https://git.drupalcode.org/project/drupal/-/merge_requests/11957

Do we need a test to prove it?

Wasn't sure tests were necessary, but it was relatively low lift, so added them.

Great. I was looking to the MR and everything looks good. I think we still miss a CR because some sites might rely on annotations precedence. I know, very unlikely, but let's add a record to announce this change.

CR https://www.drupal.org/node/3521588 →

Thank you. This looks and works as expected

Yeah agreed with the CR, seems possible that an incorrect attribute that was being ignored would start to cause problems.

I nearly went to commit this, but I think there is one comment in the test where annotation and attribute are reversed. If that's the issue, please feel free to self-RTBC after fixing it. I theoretically could have changed it on commit but would rather get confirmation that's just a typo and not anything else.

I nearly went to commit this, but I think there is one comment in the test where annotation and attribute are reversed.

Replied in MR, but comment looks correct to me. The plugin manager in that test case only looks at annotations, so for the plugin that has both, the annotation gets picked up. If that's unclear, I'm open to changes.

ohhh I see. OK back to RTBC, thanks for clarifying.

Committed/pushed to 11.x, thanks!

catch → closed merge request !11957

Published the CR