Attempt to read property uid [nid] on bool

Created on 27 October 2023, 11 months ago
Updated 29 October 2023, 11 months ago

After upgrading to PHP 8.0 I get theese warnings in webform.module, webform_submission_access
#1:

Warning: Attempt to read property "uid" on bool i webform_submission_access() (linje 632 af /var/www/www.pkt-kursus.dk/www/sites/all/modules/webform/webform.module).
Warning: Attempt to read property "sid" on bool i webform_submission_access() (linje 632 af /var/www/www.pkt-kursus.dk/www/sites/all/modules/webform/webform.module).

and
#2:Warning: Attempt to read property "uid" on bool i webform_submission_access() (linje 634 af /var/www/www.pkt-kursus.dk/www/sites/all/modules/webform/webform.module).

Warning #1 appears in this line:
$access_own_submission = isset($submission) && user_access('access own webform submissions', $account) && (($account->uid && $account->uid == $submission->uid) || isset($_SESSION['webform_submission'][$submission->sid]));
If I change "isset($submission)" to "!empty($submission)" the warning dissapears.
Perhaps it isn't enough. Perhaps I should add "!empty($submission->sid) && !empty($submission->nid)" too, to be safe?:

$access_own_submission = !empty($submission) && user_access('access own webform submissions', $account) && (($account->uid && $account->uid == $submission->uid) || isset($_SESSION['webform_submission'][$submission->sid]));
OR:
$access_own_submission = !empty($submission) && !empty($submission->uid) && !empty($submission->sid) && user_access('access own webform submissions', $account) && (($account->uid && $account->uid == $submission->uid) || isset($_SESSION['webform_submission'][$submission->sid]));

Warning #2 appears in this line:
$access_node_submissions = user_access('access own webform results', $account) && $account->uid == $node->uid;
If I add "!empty($node->uid)", the warning dissapears:
$access_node_submissions = !empty($node->uid) && user_access('access own webform results', $account) && $account->uid == $node->uid;

🐛 Bug report
Status

Needs work

Version

4.0

Component

Code

Created by

🇩🇰Denmark Uv516 Denmark

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024