- Issue created by @ressa
- Status changed to Needs review
over 1 year ago 8:58pm 26 October 2023 - Status changed to Needs work
about 1 year ago 12:50am 20 December 2023 - 🇵🇭Philippines kenyoOwen
Hi ressa
I reviewed your changes in MR!1 and the "Project name and introduction" is missing "Project page and issue queue links" and requirements section should follow README.md format
## Requirements This module requires the following modules: - [Views](https://www.drupal.org/project/views) - [Panels](https://www.drupal.org/project/panels)
Thank you.
- Status changed to Needs review
about 1 year ago 2:30am 20 December 2023 - 🇩🇰Denmark ressa Copenhagen
Sure, let's add links to project and issue queue, but since there is only one module, we shouldn't use a list.
PS. There's no need to change the Priority.
- Status changed to RTBC
about 1 year ago 1:48am 22 December 2023 - 🇵🇭Philippines kenyoOwen
Hi ressa
I noticed extra spacing between the introduction and project page so I removed it. And it now follows the README.md template. →
Thank you.
- Status changed to Needs work
6 months ago 12:12am 21 August 2024 - 🇳🇮Nicaragua dinarcon
Thanks for the MR. As of the latest release, the content MR is no longer accurate. Some notes:
- The dependency on the migrate_upgrade module has been removed.
- A new required
migrate_skip_fields_source_version
setting has been introduced. - The example of Radioactivity not offering an upgrade path is technically accurate, but the reference issue is about upgrading from Drupal 6 to Drupal 7. Can you file an issue for upgrading from Drupal 6/7 to Drupal 10/11? Then, we can link to the new issue. Or we could find a different module to use as example.
Setting back to needs work.
- 🇬🇧United Kingdom headbank
Although migrate_upgrade is not a runtime dependency, you do depend on specific migration configs generated by it, so documentation should make this clear.
- 🇳🇮Nicaragua dinarcon
Hi @headbank, you are correct. I filed 📌 Remove implicit dependency on migrate_upgrade generated migrations Active to address this situation. Can you help with that issue? Or in the meantime, update the README with information about the implicit dependency on plugin ID names?
- 🇬🇧United Kingdom headbank
As a matter of fact, the issue you've just added is the same I was thinking about raising just yesterday! I'll comment there.
I'm not schooled in contributing (beyond commenting) on issues here but I'll do my best as I've found your tutorial series (through which I discovered this module) very helpful.