- Issue created by @alorenc
- 🇳🇴Norway gisle Norway
It does not make sense to create this issue towards a tagged release when 8.x-1.x already is compatible with Drupal 10. All that remains is to create a new tagged release.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
Is the module really not compatible with Drupal 10? As far as I see, in the 8.x-1.x branch, its
core_version_requirement
value is^8.8 || ^9 || ^10
.
If the module is really not compatible with Drupal 10, this should be a bug, which could be fixed by changing thecore_version_requirement
value. (That is, if making the module compatible with Drupal 10 would not make it compatible with Drupal 8.8.)If the issue reported here is that the 8.x-1.0-alpha3 release is still using
core_version_requirement: ^8.8 || ^9
, then @gisle is correct: It should be sufficient to create a new release. - 🇳🇴Norway gisle Norway
The upgrade to Drupal 10 was a result of committing the rector patch from this issue: 📌 Automated Drupal 10 compatibility fixes Fixed , way back in September 2022. Rector is not always right – so some testing should be done – but my experiences with rector is mostly good ones.
- 🇵🇱Poland alorenc Wolsztyn, 🇵🇱
Performed manual tests. I have not found any issues on d10.
Created a new release https://www.drupal.org/project/external/releases/8.x-1.0-alpha4 →
In long term it will be good to create tests, rewrite js code (not use jQuery).
- Status changed to Fixed
8 months ago 6:15pm 29 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.