Config saved during import does not have correct initial values set

Here's a test-only patch that shows the problem we have.

The last submitted patch, 2: 3396197.test-only.patch, failed testing. View results →

I don't completely understand the underlying issue, and why this code resolves it. But the fix looks very simple and the test coverage proves this works.
Do you think it makes sense to add some kind of documentation in the code so it is is explained why we do the initWithData?

@borisson_ I debated adding a comment but everywhere in core where initWithData is called it is never documented - including in \Drupal\Core\Config\ConfigImporter::importInvokeOwner() in the same class for configuration entities. So I don't think a comment is necessary.

I think the code and test quite clearly describe the intended working. Also the added if with the initWithData describes what it's doing.

So I would dare to set this to RTBC 🙂

I also thought about asking for a comment, but when it's there, it's more like 'if there's existing data, initialize with that data', and I'm not sure how to explain that more without referencing the bug being fixed. Since this is blocking, going ahead and committing to 11.x with a cherry-pick to 10.2.x, thanks!

Also cherry-picked to 10.1.x after discussing with @alexpott, worth fixing this bug in 10.1.x in its own right, independently of bigger changes elsewhere.

Late to the party. Thanks for finding and fixing and committing this bug. It is wild that this has gone unnoticed for so long!

Automatically closed - issue fixed for 2 weeks with no activity.