- Issue created by @daffie
The database driver for MongoDB needs to override the class Drupal\Core\Entity\Sql\SqlContentEntityStorage. MongoDB does document/JSON storage instead of relational database storage.
The Comment entity is overriding that class in Drupal\comment\CommentStorage. The problem for the database driver for MongoDB is that it then also needs to override the methods in Drupal\comment\CommentStorage. It also needs to duplicate the code inside Drupal\file\FileStorage too. Duplicating code is wrong.
Another problem is that the code in Drupal\comment\CommentStorage class is that it is NOT extending the functionality from the class Drupal\Core\Entity\Sql\SqlContentEntityStorage. The extra code can easily being moved to another class.
- Create a new Drupal\comment\CommentRepository class/service and move the code/methods from Drupal\comment\CommentStorage to the new class/service.
- Deprecate the methods and the class Drupal\comment\CommentStorage.
None
- New service comment_repository with the methods getMaxThread()
, getMaxThreadPerThread()
, getDisplayOrdinal()
, getNewCommentPageNumber()
, getChildCids()
, loadThread()
and getUnapprovedCount()
.
- The methods getMaxThread()
, getMaxThreadPerThread()
, getDisplayOrdinal()
, getNewCommentPageNumber()
, getChildCids()
, loadThread()
and getUnapprovedCount()
in the class Drupal\comment\CommentStorage
are deprecated.
- The class Drupal\comment\CommentStorage
is deprecated.
None
None