- Issue created by @Grevil
- 🇩🇪Germany Anybody Porta Westfalica
Definitely yes. Should be deprecated in 2.x to reduce the risk of updaters and other contrib modules to miss the update!
https://drupalize.me/tutorial/what-deprecated-code - @grevil opened merge request.
- Assigned to Anybody
- Status changed to Needs review
8 months ago 10:19am 23 October 2023 - 🇩🇪Germany Grevil
Done, don't really like the removing of the presave hook in the submodule. Feels worse than before, but please review.
- 🇩🇪Germany Anybody Porta Westfalica
Done, don't really like the removing of the presave hook in the submodule. Feels worse than before, but please review.
But makes order and logics more clear. Less magic, clear flow.
- Assigned to Grevil
- Status changed to Needs work
8 months ago 10:26am 23 October 2023 - 🇩🇪Germany Anybody Porta Westfalica
@Grevil: commented, I think we had a misunderstanding regarding the new alter hooks use and logic. See the comments.
- Assigned to Anybody
- Status changed to Needs review
8 months ago 2:19pm 23 October 2023 - 🇩🇪Germany Anybody Porta Westfalica
All fine for 2.x! We should now add version information on the module page and inform about the hook deprecation there (and in readme?)
Super nice improvements! - Assigned to Grevil
- Status changed to Needs work
8 months ago 2:23pm 23 October 2023 - Issue was unassigned.
- Status changed to Needs review
8 months ago 3:04pm 23 October 2023 - Status changed to RTBC
8 months ago 3:06pm 23 October 2023 - Status changed to Fixed
8 months ago 3:07pm 23 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.