- Issue created by @makbay
- last update
over 1 year ago 29,672 pass - @makbay opened merge request.
- Status changed to Postponed: needs info
over 1 year ago 11:41pm 22 October 2023 Since #1938892: Switch from ISO-3166-1 country data to CLDR unicode data → Drupal uses the Unicode CLDR country list. And looking at #3044261: Update CLDR codes in CountryManager.php to latest data (35.1.0) → it seems the preferred way is to use
core/scripts/update-countries.sh
to upgrade the entire list at once.So please reconfigure this issue to do a full update of the list then reopen it with those changes.
- last update
over 1 year ago 29,673 pass - Status changed to Needs review
over 1 year ago 8:40pm 23 October 2023 - 🇹🇷Turkey makbay
Hi @cilefen,
You're right. Now the list is fully updated including a new country called Sark. Greetings from Türkiye to all the people of Sark :)
- 🇹🇷Turkey makbay
Attached is the latest list from CLDR.
Actually, the way that CLDR publishes the json is also changed. I'll be also creating an issue to fix the description text inside the update-countries.bash
- Status changed to Needs work
over 1 year ago 10:16pm 23 October 2023 - Status changed to Needs review
over 1 year ago 8:50am 25 October 2023 - Status changed to Needs work
over 1 year ago 9:10am 25 October 2023 The maintainers will not commit this issue in its current state, with the code doing one thing—updating all countries to a specific CLDR version—and the issue summary and title referring to changing one country.
- Status changed to Needs review
over 1 year ago 4:23pm 25 October 2023 - 🇹🇷Turkey makbay
@cilefen, hope it's ok now. Please feel free to change the title and/or issue summary in order to make this go through. Contributing should not be this hard and discouraging.
I acknowledge your perspective about contributing. But, Drupal Core has 1008 issues in need of review as I write this. What can we do but ask the contributors to make changes as ready as possible? This issue has been open for four days...
To review I am trying to repeat your actions to derive the same diff. But I have been unable to have any success:
php core/scripts/update-countries.sh
results in fatal errors from undefined functions when core/lib/Drupal/Core/Locale/CountryManager.php is imported.vendor/bin/drush php:script core/scripts/update-countries.sh
executes but results in:'AC' => t(), 'AD' => t(), 'AE' => t(), 'AF' => t(), 'AG' => t(), // ...
What am I doing wrong?
- 🇹🇷Turkey makbay
Actually I ran the script on a D9.5 site and copied the output from there.
Seems we have another issue here.
- Status changed to Needs work
over 1 year ago 3:25pm 2 November 2023 - 🇺🇸United States smustgrave
Could the MR be updated for 11.x please as that's the current development branch.
- @makbay opened merge request.
- Status changed to Needs review
over 1 year ago 7:00pm 6 November 2023 - Status changed to RTBC
over 1 year ago 8:53pm 7 November 2023 - 🇺🇸United States smustgrave
Failure to TimestampFormatter seems unrelated and am seeing across a few issues.
To confirm the task https://www.npr.org/2023/01/08/1147704945/the-state-department-will-begi... shows the name has changed.
- last update
over 1 year ago 29,678 pass - Status changed to Fixed
over 1 year ago 10:07pm 7 November 2023 - 🇬🇧United Kingdom longwave UK
Confirmed the spelling change for Turkey and the addition of Sark in the Unicode CLDR source data.
Not eligible for backport to 10.1.x due to string changes, but good to get this into 10.2.0.
Committed and pushed 4a02d92523 to 11.x and eee9c57f01 to 10.2.x. Thanks!
-
longwave →
committed eee9c57f on 10.2.x
Issue #3395852 by makbay, smustgrave, cilefen: Update the countries list...
-
longwave →
committed eee9c57f on 10.2.x
-
longwave →
committed 4a02d925 on 11.x
Issue #3395852 by makbay, smustgrave, cilefen: Update the countries list...
-
longwave →
committed 4a02d925 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.