- Issue created by @joshuasosa
- 🇮🇳India chetan 11
chetan 11 → made their first commit to this issue’s fork.
- Status changed to Needs review
about 1 year ago 5:44pm 22 October 2023 - 🇺🇸United States joshuasosa
@chetan-11 Thanks for getting it started! There's some more work needed, but I'm not sure how to work with that merge request.
Attached is a patch that adds more fixes after MR!1.
I'm also getting this deprecation notice but am unsure how to fix it:
Deprecated function: Implicit conversion from float 2551442.86108 to int loses precision in Drupal\moon_phases\MoonCalc->setPositionInCycle() (line 87 of modules/contrib/moon_phases/src/MoonCalc.php).
But that notice doesn't normally show unless you enable display errors or look at the log. I think this patch is ready for review, and that deprecation notice could be addressed in a future issue.
- Assigned to AstonVictor
- Issue was unassigned.
- Status changed to Fixed
11 months ago 2:56pm 2 January 2024 - 🇺🇦Ukraine AstonVictor
Prepared and merged the base changes for Drupal 10.
It's possible to add a moon block and use
/moon-phases/{DATE}&/moon-phases/month/{DATE}routes.
Other fixes/changes will be made in separate issues. Automatically closed - issue fixed for 2 weeks with no activity.