- Issue created by @amateescu
- Status changed to Needs review
about 1 year ago 12:48pm 20 October 2023 6:03 4:53 Running- 🇷🇴Romania amateescu
This should do it.
Adding a test for this one-line fix would be quite hard, because we'd have to simulate the conditions described in the issue summary and somehow add a safeguard for the infinite loop. Per 🌱 [policy, no patch] Better scoping for bug fix test coverage RTBC , I think we shouldn't require a test here.
- Status changed to RTBC
about 1 year ago 2:42pm 20 October 2023 - 🇺🇸United States smustgrave
As submaintainer of this component going to rely on you that this won't need a test case.
Change seems simple enough and didn't break anything.
- last update
about 1 year ago 30,426 pass - last update
about 1 year ago 30,434 pass 14:40 41:17 Running- last update
about 1 year ago 30,464 pass - last update
about 1 year ago 30,481 pass - last update
about 1 year ago 30,483 pass - last update
about 1 year ago 30,486 pass - last update
about 1 year ago 30,486 pass - last update
about 1 year ago 30,493 pass - last update
about 1 year ago 30,516 pass - Status changed to Needs work
about 1 year ago 12:14am 11 November 2023 The Needs Review Queue Bot → tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- Status changed to RTBC
about 1 year ago 8:51am 22 November 2023 - 🇬🇧United Kingdom catch
When a module provides base fields for the User entity type, and uses an entity query in hook_entity_base_field_info() to determine them,
This sounds like a very bad idea, but also something that doesn't need explicit test coverage for. The condition is the same, it's just returning early from the other half.
Committed/pushed to 11.x and cherry-picked to 10.2.x, thanks!
- Status changed to Fixed
11 months ago 10:27am 21 December 2023 - Status changed to Fixed
11 months ago 10:39am 4 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.