- Issue created by @roderik
- Status changed to Needs review
over 1 year ago 8:56am 23 October 2023 - ๐ฎ๐ชIreland lostcarpark
Thanks, @Aditi Saraf,
Could you explain the rationale behind some of these?
Are the symbols used related to the SAML project?
I've looked for an official SAML project logo, but as far as I can tell, there isn't one. A couple have been proposed, but don't seem to have been adopted.
If any of these are related to the project, they could be beneficial, but if they are not, or are proposed logos that weren't adopted, it could cause confusion. - ๐ฎ๐ณIndia AditiVB
Hi @lostcarpark . Thanks for reviewing this issue . But these symbols are not used related to SAML project , I am new to Drupal contribution and this is my first issue for logo creation . The logo that i have suggested , created my self .
- Status changed to Needs work
over 1 year ago 6:07am 31 October 2023 - ๐ฎ๐ณIndia urvashi_vora Madhya Pradesh, India
No worries, @Aditi Saraf.
We've all had our first contributions, and it's a learning process for everyone. Here's a suggestion: please take a moment to thoroughly read the issue summary before starting your work. I noticed that a couple of the logos you created exceed the required file size limit (should be under 10K). Additionally, when designing logos, it's a good practice to begin by searching for existing logos, and if none are available, search for relevant symbols and elements. Try to avoid incorporating text in logos whenever possible, as it often makes the design more versatile and timeless.
Moving the issue back to Needs work.
- ๐ฎ๐ชIreland lostcarpark
SAML is an XML based security protocol, so my thought is a secure site symbol in a set of XML brackets, something like the following:
<๐/>
Anyone like to give it a try?
- Status changed to Needs review
over 1 year ago 10:13am 31 October 2023 - ๐ฎ๐ณIndia urvashi_vora Madhya Pradesh, India
Please review. I have also tried with the SAML logo.
Thanks
- ๐ง๐ชBelgium BramDriesen Belgium ๐ง๐ช
I like "saml-authentication-logo-2.png" from #11 Looks clean!
- Status changed to RTBC
over 1 year ago 12:54pm 9 November 2023 - ๐ฎ๐ชIreland lostcarpark
Agreed. Great work, @urvashi_vora.
Thanks for your work, @roshni27, but your suggestions feel a little overcomplicated. - Status changed to Needs work
about 1 year ago 11:19pm 5 February 2024 - ๐ช๐จEcuador jwilson3
It looks like the proposed resolution (in issue summary) is this one:
https://www.drupal.org/files/issues/2023-10-31/saml-authentication-logo-... โ
But it looks weird to my eye that the lock has square edges while the angle brackets are rounded. I would go with either square edges everywhere, or rounded edges everywhere.
Is there an SVG of this proposal?
- Assigned to Kristen Pol
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
I'm going to take this one and see if one of my interns can help today.
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
Hiding the other logos to avoid confusion.
- ๐บ๐ธUnited States AaronDeutsch California
I made some tweaks here with two options, one with and without the rounded corners. Let me know if this needs further revision, thank you!
- Issue was unassigned.
- Status changed to Needs review
9 months ago 8:23pm 16 July 2024 - ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
Thanks! I don't have a strong opinion on which one. Marking for review for more eyes :)
- ๐ฎ๐ชIreland lostcarpark
I definitely prefer the rounded version to the sharp version. I'm not clear on what's changed between @urvashi_vora's logo and @AaronDeutsch's version. I can see some square corners on the lock have been rounded off. Anything else?
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
#16 said:
I would go with either square edges everywhere, or rounded edges everywhere.
so that's the changes :)
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
Updating the summary with both options.
- ๐บ๐ธUnited States AaronDeutsch California
I added a little bit of roundness to the top of the lock and keyhole to make it feel more cohesive, and also yes I rounded the body of the lock as well.
- ๐ฎ๐ชIreland lostcarpark
Oh yes, I'd forgotten that comment. +1 for option 1, the rounded version.
- Status changed to RTBC
9 months ago 5:56pm 18 July 2024 - ๐ง๐ชBelgium BramDriesen Belgium ๐ง๐ช
Looks good to me :-) I also prefer the rounded version
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
Thanks, everyone! I'm updating the summary to only show the rounded one, and hiding the other file.
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
I don't see this in the top 100 list so I assume it should be moved to the project's issue queue:
https://docs.google.com/spreadsheets/d/1uZULaKLt5nwzYfzsrIUYLPEEO1dZFl5c...
- Status changed to Fixed
3 months ago 12:42pm 29 December 2024 - ๐ณ๐ฑNetherlands roderik Amsterdam,NL / Budapest,HU
Thank you. Took a while, but now added to samlauth module.
Automatically closed - issue fixed for 2 weeks with no activity.
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
@roderick could you give the logo creators and contributors issue credit by creating a new comment and checking their checkboxes in the credit and committing section and saving the comment? You can credit people this way including yourself and itโll show up on their profile page. Thanks
- ๐ง๐ชBelgium BramDriesen Belgium ๐ง๐ช
This is the project_browser issue queue though. So a maintainer here should do that.
Only place where @roderik can do this is in the module he maintains, this issue I guess: https://www.drupal.org/project/samlauth/issues/3413865 ๐ Add logo Needs work
- ๐ณ๐ฑNetherlands roderik Amsterdam,NL / Budapest,HU
Thanks for the reminder. I guess I should have not closed this stale issue myself, because of the missing credit that I can't assign.
In principle it seems better to assign here -- ๐ Add logo Needs work was just a throwaway reminder issue (without credit) to add the SVG file. But since I don't really know the maintainer situation here and I don't want to cause more indirect communication... I added the credit in there.
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
Thanks! Iโm realizing that this issue probably shouldโve been moved to the other queue but your workaround is good ๐