[CKE5] Make Modify table attributes filter work with CKE5

Created on 17 October 2023, 8 months ago
Updated 18 October 2023, 8 months ago

Problem/Motivation

I am moving a project from CKE4 to CKE5, and the text format in question uses the "Modify table attributes (WxT)" filter. When I try to change the text editor from Ckeditor to CKEditor5 I get this error:

CKEditor 5 only works with HTML-based text formats. The "Modify table attributes (WxT)" (wxt_add_table_attribute_filter) filter implies this text format is not HTML anymore.

Steps to reproduce

Enable a CKE4 text format with the "Modify table attributes (WxT)" filter enabled. Change the text format to Ckeditor5, ans see error.

Proposed resolution

Chnage filter from type TYPE_MARKUP_LANGUAGE to TYPE_TRANSFORM_IRREVERSIBLE.

πŸ› Bug report
Status

Fixed

Version

5.0

Component

User interface

Created by

πŸ‡¨πŸ‡¦Canada smulvih2 Canada 🍁

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @smulvih2
  • Status changed to Needs review 8 months ago
  • πŸ‡¨πŸ‡¦Canada smulvih2 Canada 🍁

    Patch fixes the issue and now I can change my text format to CKE5.

  • Status changed to Fixed 8 months ago
  • πŸ‡¨πŸ‡¦Canada sylus

    I'll admit to not fully understanding this one but I think the change makes sense?

    FilterInterface::TYPE_TRANSFORM_IRREVERSIBLE β€” Irreversible transformation filters. The filter performs a transform for which a WYSIWYG plugin does not exist to perform the transformation client-side (especially, the reverse of it); instead, the WYSIWYG editor displays the unfiltered text. For example, Token Filter.

    Thanks for testing this one and will just take your word on it :)

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024