- Issue created by @Gautam_105@
- First commit to issue fork.
- @shiv_yadav opened merge request.
- Status changed to Needs review
about 1 year ago 10:36am 17 October 2023 - š®š³India shiv_yadav
Hello arti_parmar, I have fixed this issue.create MR & attached screenshot as well.
Please review & retest it .
Thanks. - š®š³India jay jangid Jaipur
Hello @shiv_yadav,
I have tested this issue & verified your MR Drupal 9.5.x.
Result:- After MR applied Twitter Logo changed to X.
I am sharing before & after state screenshots .
Thanks. - š®š³India Kanchan Bhogade
Hi,
I've tested MR!27 on Drupal 10
But MR is failingAdding SS for reference
- šµšPhilippines cleavinjosh
Hi @shiv_yadav,
I applied MR!27 on Drupal 10.1.8.
ā fashion_beauty git:(main) ā curl https://git.drupalcode.org/project/fashion_beauty/-/merge_requests/27.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 2292 0 2292 0 0 4951 0 --:--:-- --:--:-- --:--:-- 4950 patching file templates/layout/page.html.twig patching file ultimate_slider.libraries.yml Hunk #1 succeeded at 3 with fuzz 2. ā fashion_beauty git:(main) ā
However, the icons aren't showing after the patch.
Please see my attachments for reference.
I will retain the status so that others can review as well.
Thank you. - Status changed to Needs work
3 months ago 11:03am 10 September 2024 - šµšPhilippines cleavinjosh
Hi,
I applied MR!27 it was applied smoothly and the changes are reflected.
Drupal Core: 10.3.2
ā fashion_beauty git:(1.0.x) curl https://git.drupalcode.org/project/fashion_beauty/-/merge_requests/27.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 2292 0 2292 0 0 5269 0 --:--:-- --:--:-- --:--:-- 5268 patching file templates/layout/page.html.twig patching file ultimate_slider.libraries.yml ā fashion_beauty git:(1.0.x) ā
Before:
After:
Issue/Concern
- The Youtube link is gone after applying MR!27.
I apologize for my previous testing, I think that was because of some conflicts on my local or some cache issue.
Moving the status to Needs work.
Please check and advise.
Thank you.