Media library integration does not work well for fields that accept multiple values

Open on Drupal.org →

Created on 17 October 2023, 8 months ago

Updated 2 February 2024, 5 months ago

Problem/Motivation

In 📌 Add media library support Fixed an integration with Media Library was introduced. For a media reference field that accepts multiple values the integration is not working well (yet).

We have a media field in which we can upload multiple images. This works fine with the default widget. A system dialog opens and we can upload multiple images at once. We have customers that (want to) upload a lot of large image files at once and they might encounter issues (e.g. server limits). To better support this it would be nice if we can use the File Resumable Upload module.

If we enable the dev version the File Resumable Upload module, including the work from issue 📌 Add media library support Fixed , the multiple file upload is replaced by the interfaces provided by this module. But then both the drop area and the system dialog via the Browse button only support one file at a time.

When I edit \Drupal\file_resup\Form\FileFormAlterBase::formAlter() and hardcode the $cardinality to -1 I can upload multiple image files at once. The upload works fine, but only the first image is added to the media library.

Steps to reproduce

- Install Drupal 9.5.x
- Enable Media Library (and its dependencies)
- Make sure a media type supporting file uploads exists (file, image)
- Create an entity type with a media reference field accepting multiple values and allow a file media type to be referenced
- Make sure the set the media library widget for the field
- Verify that multiple files can be uploaded / referenced at once
- Add and enable the File Resumable Upload module
- See that now only a single file can be uploaded / reference at once

Proposed resolution

The Media Library module itself calculates the number of available slots on the media reference field to determine the cardinality for the file upload field in the widget. We might be able to do the same.

We also need to fix that multiple files can be added as references directly after uploading. No idea yet about how to fix it.

Remaining tasks

-
-
- Review MR
- Merge MR

User interface changes

Multiple files can be uploaded in the media library widget with File Resumable Upload enabled.

API changes

N/A

Data model changes

N/A

🐛 Bug report

Status

Fixed

Version

1.0

Component

Code

Created by

🇳🇱Netherlands ricovandevin

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!4Media library integration does not work well for fields that accept multiple values
Merged
🇳🇱Netherlands ricovandevin
updated 5 months ago

Comments & Activities

Issue created by @ricovandevin
Assigned to ricovandevin
Status changed to Needs work 8 months ago1:05pm 23 October 2023
Comment 8 months ago →
🇳🇱Netherlands ricovandevin
Started with the cardinality / max files. Actually inserting the newly uploaded files into the media library is still to be done.
Merge request !4Resolve #3394510 "Media library integration" → (Merged) created by ricovandevin
Status changed to Needs review 8 months ago2:04pm 23 October 2023
Comment 8 months ago →
🇳🇱Netherlands ricovandevin
$resup_file_ids = explode(',', $input['resup']); $resup_file_id = reset($resup_file_ids);
The above piece of code from \Drupal\file_resup\Form\FileFormAlterBase::fileValue() is the reason that the widget does not insert multiple images, even if multiple images are upload in one go.

The MR fixes both the cardinality / max files and the insertion of multiple images at once.

A patch of the MR is attached to this comment.
Status changed to RTBC 8 months ago6:17pm 8 November 2023
Comment 8 months ago →
🇺🇸United States Tim Bozeman
This is great ricovandevin. Thank you very much!
Comment 5 months ago →
System Message

anrikun → committed f35e7796 on 8.x-1.x authored by ricovandevin →
Resolve #3394510 "Media library integration"
Status changed to Fixed 5 months ago9:30pm 19 January 2024
Comment 5 months ago →
🇺🇸United States Tim Bozeman
Comment 5 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024