- Issue created by @pooja_sharma
- First commit to issue fork.
- @shiv_yadav opened merge request.
- Status changed to Needs review
about 1 year ago 12:15pm 17 October 2023 - 🇮🇳India shiv_yadav
Hello Pooja , i have fixed this issue. created MR.
please review & retest it.
Thanks. - Status changed to Needs work
about 1 year ago 2:40pm 22 October 2023 While testing code after applying mentioned changes , issue is not fixed
- 🇮🇳India shiv_yadav
Hello pooja, I have not got any error. remove button working fine for me.
This issue is not fixed
If "Enabled" checkbox is unchecked by user for particular entry then "pages" field should not require and should able to save the formSee the attachment & I removed the value from "pages" column, still validation throws on pages field column require not letting me save the form.
- 🇮🇳India mukhtarm
I think after the patch, it's working as expected. Thanks @@shiv_yadav
Although, there are tweaks can be applied to the workflow i think:
1) If there is only one entry, first clicking on
Remove
it will clear the item in the form only (Instead it can be directly do the step 2 i think, if there is only one entry). Then on submitting the form it won't allow because we have to enter the pages :). This is a legitimate validation.2) Again clicking on the
Remove
button after step 1 without saving, it will remove the entry completely and will show a message :
"There are no items yet. Add an item."
And then saving the form will give you a fresh entry form.