- Issue created by @claudiu.cristea
- last update
8 months ago Composer require-dev failure - @claudiucristea opened merge request.
- Status changed to Needs review
8 months ago 3:14pm 16 October 2023 - π·π΄Romania claudiu.cristea Arad π·π΄
The tests are failing but this is independent from this issue, they are red also in HEAD
- Status changed to Needs work
8 months ago 8:32am 17 October 2023 - ππΊHungary huzooka Hungary ππΊπͺπΊ
NW because of https://www.drupal.org/project/search_api/issues/3394367#mr95-note218856 π Not all fields that have a target_type setting are entity references Fixed
- last update
8 months ago Composer require-dev failure - Status changed to Needs review
8 months ago 9:56am 17 October 2023 - π·π΄Romania claudiu.cristea Arad π·π΄
Fixed the review remarks. Back to "Needs review"
- Status changed to RTBC
8 months ago 9:50am 18 October 2023 - last update
8 months ago 543 pass, 2 fail - π¦πΉAustria drunken monkey Vienna, Austria
As mentioned in the other ticket, HEAD tests arenβt actually red, testing issue forks just doesnβt work for this project. See #3190024: Problem with test dependencies when testing issue forks β . Therefore, please always post patches for when you want changes to be reviewed (even when working in an issue fork).
Posting your MR as a patch. The last submitted patch, 8: 3394367-8--views_data_proper_entity_ref_check.patch, failed testing. View results β
- last update
8 months ago 545 pass - Status changed to Needs review
8 months ago 11:53am 29 October 2023 - π¦πΉAustria drunken monkey Vienna, Austria
Test fail was a fluke.
Anyone still wants to review, or OK to merge like this? - last update
7 months ago 545 pass - π¦πΉAustria drunken monkey Vienna, Austria
Attaching a re-roll. Last chance to test/review.
-
drunken monkey β
committed 9178fc9c on 8.x-1.x authored by
claudiu.cristea β
Issue #3394367 by claudiu.cristea, huzooka, drunken monkey: Fixed false...
-
drunken monkey β
committed 9178fc9c on 8.x-1.x authored by
claudiu.cristea β
- Status changed to Fixed
7 months ago 5:57pm 10 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.