[1.0.x] Lottiefiles Field Formatter

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

No issues found. Moving to RTBC

• What follows is a quick review of the project; it doesn't mean to be complete
• For each point, the review usually shows some lines that should be fixed (except in the case the point is about the full content of a file); it doesn't show all the lines that need to be changed for the same reason
• A review is about code that doesn't follow the coding standards, contains possible security issue, or doesn't correctly use the Drupal API; the single points aren't ordered, not even by importance

    $element['background'] = [
      '#title' => $this->t('Background Color'),
      '#type' => 'textfield',
      '#size' => 10,
      '#description' => $this->t("Enter color code in the format '#FFFFFF'. By default, the background is 'transparent' and will take the color of the parent container."),
      '#default_value' => Xss::filter($this->getSetting('background')),
      '#required' => TRUE,
    ];

The default values for form elements are not sanitized.

    $summary[] = $this->t('Controls: %controls', ['%controls' => $this->getSetting('controls') ? $this->t('Yes') : $this->t('No')]);
    $summary[] = $this->t('Count:') . $this->getSetting('count');
    $summary[] = $this->t('Direction:') . $this->getSetting('direction');
    $summary[] = $this->t('Hover: %hover', ['%hover' => $this->getSetting('hover') ? $this->t('Yes') : $this->t('No')]);
    $summary[] = $this->t('Loop: %loop', ['%loop' => $this->getSetting('loop') ? $this->t('Yes') : $this->t('No')]);
    $summary[] = $this->t('Mode:') . $this->getSetting('mode');

Instead of concatenating a translated string with a dynamic string, the code should always use placeholders in the translated string.

  /**
   * Format the settings as attributes.
   */

The verb in the description must be declined to the third person singular. The description for the return value must be provided too.

Furthermore, the project page should describe the differences between this module and the Lottiefiles Field → module, for example.

I am changing priority as per Issue priorities → .