- Issue created by @generalredneck
- πΊπΈUnited States generalredneck
So looking into it... The change was made between 1.2 and 1.3 here: https://git.drupalcode.org/project/entity_browser_enhanced/-/commit/6258...
I think someone got confused between what the tilde
~
and the carat^
For one... based on that change up until that point, the dependency criteria was TECHINCALLY different but functioned the same because of the way it was written. composer.json contained
"drupal/core": "~8.0 || ~9.0 || ~10.0",
and entity_browser_enhanced.info.yml containedcore_version_requirement: ^8 || ^9 || ^10
I think this lead someone to believe that ^ and ~ were the same. Let me see if I can explain.
~
is the magic operator here. If you write~10.0
that means >=10.0 <11.0.0. If you write~10.0.0
that means >=10.0.0 <10.1.0. Another way of looking at it is that using~
specifies a minimum version, but to go up.^
on the other hand sticks to non-breaking changes by allowing all versions to upgrade except major versions... So in that example^10.0.0
and^10.0
are equivalent. This is the case for all versions greater than 1.0.0. Check out https://getcomposer.org/doc/articles/versions.md#next-significant-releas...So I'm going to make a MR with the changes.
- @generalredneck opened merge request.
- π―π΄Jordan Rajab Natshah Jordan
Agrees, with you Allan.
Changing it to "^9 || ^10"
Only trying to push teams to use~10.1.0
and later.
Maybe not everyone is ready for:Drupal 9 support will end in November 2023 β
November 1, 2023 (UTC) Drupal 9 reaches end-of-life due to its dependency on Symfony 4.
Reference: Symfony 4.4 release checker.
What to do about Drupal 9's end of life in November 2023Also Drupal ~10.0.0 went out of support
Not even listed in the Drupal core release cycle βIt feels that, not everyone is ready to jump to
~10.1.0
with all of that:- Loosen the restrictions a bit
- Smoother upgrade process
Switching to
^9 || ^10
-
Rajab Natshah β
committed fac29979 on 2.0.x authored by
generalredneck β
Issue #3393982 by generalredneck: Loosen the restrictions for Entity...
-
Rajab Natshah β
committed fac29979 on 2.0.x authored by
generalredneck β
- πΊπΈUnited States generalredneck
On the contrary, it is mentioned in the 10.2.0 development cycle:
https://www.drupal.org/about/core/policies/core-release-cycles/schedule#... βWeek of December 11, 2023 (UTC)
Drupal 10.2.0 released.
End of security support for 10.0.x.Again, you say
~10.1.0 and later.
I think you mean ^10.1.0 in that statement. because ~10.1.0 is == 10.1.* and would not support later versions of drupal.
- π―π΄Jordan Rajab Natshah Jordan
Yes, Allan
I treated this module as part of the Varbase Media β ecosystem and development team rules.
That was wrong.You are right public used contrib modules should allow for more flexibility.
looking at the best.
https://www.drupal.org/project/webform β
https://www.drupal.org/project/ctools βSwitching to
"^9 || ^10"
- πΊπΈUnited States generalredneck
Rajab,
I hope I didn't offend, I was trying to help understanding, not beat an admission of guilt out of you. I hope that I'm just reading too much into your words, but If there are any hard feelings, lets talk, and feel free to slack with me on ways I can improve the way I communicate.
You are not "wrong" and I can see where you come from. Thanks for working with me on this.
- π―π΄Jordan Rajab Natshah Jordan
Not at all, Allan
I enjoy the subject of packaging and having the best option at the time.
Thanks for reporting, and following up with the MR.
We will be open to change that in 1 month or 1 year to drop support for Drupal 9. or may not, we do not know, we may keep the ^9 and add the ^11 and start playing with D11 :)Better not to have any development branches@dev
requiredpackages/libraries
, better with@stable
versions(~1.0
,~2.0
,~3.0
,~4.0
, ext... ). not to bring anyalphas
,betas
,RCs
on a production site.It is a way between drupal/core and drupal/core-recommended
By the way I'm with the Drupal Core Recommended way with Tilde Version Range (~) and all 3 part of the version.
I'm pushing to move everything to that. Some time it dose not work.
I'm passing the recommended way for this module for the most generals way. Only to allow for a smoother upgrade process
-
Rajab Natshah β
committed 8005e5ee on 2.0.x authored by
generalredneck β
Issue #3393982 by generalredneck: Loosen the restrictions for Entity...
-
Rajab Natshah β
committed 8005e5ee on 2.0.x authored by
generalredneck β
- Status changed to Needs review
about 1 year ago 3:19pm 13 October 2023 -
Rajab Natshah β
committed e1b4ea90 on 8.x-1.x authored by
generalredneck β
Issue #3393982 by generalredneck: Loosen the restrictions for Entity...
-
Rajab Natshah β
committed e1b4ea90 on 8.x-1.x authored by
generalredneck β
- π―π΄Jordan Rajab Natshah Jordan
β Released entity_browser_enhanced-8.x-1.4 β
- Status changed to Fixed
about 1 year ago 3:33pm 13 October 2023 - π―π΄Jordan Rajab Natshah Jordan
β Released entity_browser_enhanced-2.0.0 β
Automatically closed - issue fixed for 2 weeks with no activity.