Unable to Disable TFA for a user.

Hi @cmlara,

I have fixed the issue in MR, please review and verify.

Added comments in the MR, setting back to NW for their resolution.

Hi @cmlara,

Please share the reproduce steps, i'm not able to clone this module on my local.

I'm wondering if I'm not understanding your response, are you attempting to resolve issues without having the module installed?

If you mean reproducing the MR comments, part of reproducing is from Human Review, and the other is from PHPStan which can be tested with phpstan analyze ./ from the modules directory (this does require downloading the module into a development lab), we also include the results in our GitLab CI tests.

If you mean reproducing the bug, the (high level) steps are included in the Issue Summary, reproducing does require having the module installed to test.

Got hit by this issue, when trying to fix 🐛 Wrong domain name for Google Authenticator on TOTP and HOTP setup page Needs review on dev branch.

Can confirm, patch resolves the issue.

But seems Doc Block type hint is not updated to match the variable type ?

Seems @cmlara already commented on the issue, I updated the PHPDoc block.

Addressed review comments, please re review.

LGTM, merged to dev. Thank you!

Automatically closed - issue fixed for 2 weeks with no activity.