- Issue created by @Grevil
- First commit to issue fork.
- Status changed to Needs work
about 1 year ago 1:23pm 23 October 2023 - Status changed to Needs review
about 1 year ago 2:16pm 23 October 2023 - 🇩🇪Germany lrwebks Porta Westfalica
Done with this one so far!
@Anybody, when you're reviewing: NOTE that the new update hook is #9008 because of another issue about to be merged having a new update hook #9007! Please merge that one first! - Assigned to Grevil
- Assigned to lrwebks
- 🇩🇪Germany Grevil
LGTM!
One last thing, we still need to create a links.task.yml, otherwise there will be no translatable tab on the settings page:
- Next, create the link to the translation page on the settings page, using a "my_module.links.task.yml": ~~~ my_module.settings: title: 'my_module Settings' route_name: my_module.settings base_route: my_module.settings ~~~
- Status changed to Needs work
about 1 year ago 1:45pm 30 October 2023 - Status changed to Needs review
about 1 year ago 1:53pm 30 October 2023 - 🇩🇪Germany lrwebks Porta Westfalica
I have renamed the update hook, however I'm not sure what you mean with comment #8 - due to the config_translation.yml the translation tab will appear automatically in the form of "Translate 'Photoswipe Settings'" without the need for a manual tab creation via the tasks.yml, at least it worked for me...
- Status changed to Needs work
about 1 year ago 2:29pm 30 October 2023 - 🇩🇪Germany Grevil
@LRWebks not if we only have the photoswipe module installed! Try it yourself by uninstalling all photoswipe submodules and go to the settings page. The translatable tab will only get added, if tabs already exist (which is the case, when activating the dynamic_caption submodule but not when only photoswipe is enabled).
- Status changed to Needs review
about 1 year ago 9:10am 3 November 2023 - 🇩🇪Germany lrwebks Porta Westfalica
Added the
links.task.yml
and it works now! Back to review. - Assigned to Grevil
- 🇩🇪Germany Anybody Porta Westfalica
LGTM! @Grevil if you should have the time, please take a final look.
- 🇩🇪Germany lrwebks Porta Westfalica
Perhaps as @Grevil is currently not able to take a look, we should set it to RTBC or invite someone else from Photoswipe in to take a look...
- Assigned to Anybody
- 🇩🇪Germany Anybody Porta Westfalica
I'll review and test it when I have the time, thanks!
- Assigned to Grevil
- Status changed to RTBC
12 months ago 10:50am 10 January 2024 - 🇩🇪Germany Grevil
Code LGTM and update hook / functionality works perfect!
Well done @LRWebks!
- Status changed to Fixed
12 months ago 10:58am 10 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.