Create a photoswipe setting for "mainClass"

@Grevil: What's the default value for mainClass?

@Grevil: All clear now, I looked into https://github.com/dimsemenov/PhotoSwipe/blob/2d23b36c99411d2dc45bf66104... and added the infos above!

Default should be NULL, as it already is set as the default in this module (so no need to change the default value).
See https://photoswipe.com/options/#mainclass, where it is set as "undefined".

Working on this now - should be quick!

Done already! Tiniest issue I've ever worked on, but still important. Please review!

Thanks. That's indeed all, as the value is already part of the existing schema and config.

Whoops, forgot to update the settings test, does this need another review? Putting it to "needs review" anyway so you can take notice!

Is this already tested? Since the default value on installation for "mainClass" is NULL instead of an empty string.

So after installation, as soon as we go to the settings page and change anything, except "mainClass", the current implementation will override the mainClass value from NULL to an empty string. If the photoswipe js library simply handles an empty string the same as NULL everything is fine, and we can set the default value from mainClass to an empty string ''. But it might not, this should be checked first!

we can set the default value from mainClass to an empty string ''

I think this should be prefered, as the form will also set ''.

If it doesn't work, we'd have to cast to NULL on save. You could also just look into the PS JavaScript code, how it is handled and if it leads to different results.

I think this should be prefered, as the form will also set ''.

Yep, this is what I meant!

So, should I change the default value to an empty string? Would be a quick fix and then we're done here...

@LRWebks yes!

Well, indeed a quick fix! Done.

@Anybody please review if you find the time, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

LRWebks → changed the visibility of the branch 3393158-create-a-photosipe to hidden.

LRWebks → changed the visibility of the branch 3393158-create-a-photosipe to active.