- Issue created by @Anybody
- @anybody opened merge request.
- Assigned to thomas.frobieter
- Status changed to Needs review
about 1 year ago 2:50pm 10 October 2023 - 🇩🇪Germany Anybody Porta Westfalica
@thomas.frobieter please try, if it fixes the issue (and still works for all other cases).
Another alternative would have been to move the
->attach()
intotemplate_preprocess_photoswipe_(responsive_)image_formatter
in photoswipe.theme.inc but then we'd also have to handle the overwritten (third party / formatter) settings there. Might also be a viable solution if this one shouldn't work.We should try this with care, as there's a risk of multi-initialization now. Attaching to the field was definitely the smarter and less risky approach.
- 🇩🇪Germany Anybody Porta Westfalica
I also reported the issue over at twig_field_value: 🐛 |field_value removes attached libraries from $build Active is I think it might be seen as a bug over there!
If they agree and find a fix, we should consider reverting this. - Status changed to RTBC
about 1 year ago 3:00pm 10 October 2023 Looks good! Library is loaded correctly together with the field_value formatter
- Issue was unassigned.
- 🇩🇪Germany Anybody Porta Westfalica
Ok tests are also all green, so let's merge this into dev and see if we get any errors reported. I made a fresh rc3 release before with the other fix.
- Status changed to Fixed
about 1 year ago 3:12pm 10 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.