- Issue created by @anand.toshniwal93
- Issue was unassigned.
- Status changed to Needs review
9 months ago 4:07am 11 October 2023 - last update
9 months ago 14 pass - Status changed to Needs work
9 months ago 8:50am 11 October 2023 - 🇦🇺Australia darvanen Sydney, Australia
Thanks for this, there are a couple of complications we'll need to sort out first.
If we commit this patch as-is it will revert any sites that have gone to the effort of installing the library to using the CDN which isn't necessarily going to break them, but could cause some outages.
I agree that installing with composer is ideal - can you provide the method with which you achieved that? Perhaps we can roll that into the module.
If we can automate the library inclusion in a standardised and future-proofed way, it's probably worth a minor release with a big fat warning on it and remediation instructions as there are already over 1k sites reporting usage of 4.1.x.
- 🇦🇺Australia darvanen Sydney, Australia
While adding GitLab CI I switched the builder from gulp to vite, it would be very easy to bundle the library directly into this package and I'm tempted to do so.
- Status changed to Postponed: needs info
25 days ago 2:12pm 1 June 2024 - 🇦🇺Australia darvanen Sydney, Australia
@anand.tshniwal93 I've come back to review this and I have to ask - how are you using composer to install an npm dependency? That is not something supported by composer.
I'm going to mark this postponed for a minimum of 1 month for further feedback, and potentially close as "works as designed" after that.
I'd encourage anyone having issues with JS dependencies to check out a work-in-progress solution to this problem at https://github.com/darvanen/drupal-js
- Assigned to darvanen
- Status changed to Active
6 days ago 3:54am 20 June 2024 - 🇦🇺Australia darvanen Sydney, Australia
As of 4.2.0 the slide-element library is now bundled into the built code. It is no longer necessary to mess around with CDNs or downloaded libraries. I'm updating the readme to reflect this.
-
darvanen →
committed b1583461 on 4.x
Issue #3392947 by darvanen: Update readme to reflect JS library download...
-
darvanen →
committed b1583461 on 4.x
- Issue was unassigned.
- Status changed to Fixed
6 days ago 4:00am 20 June 2024