- Issue created by @s_leu
- Status changed to Needs review
over 1 year ago 10:47am 9 October 2023 - last update
over 1 year ago Patch Failed to Apply - Status changed to Needs work
over 1 year ago 2:44pm 9 October 2023 - 🇺🇸United States smustgrave
Thank you for reporting.
Will need a test case showing the bug.
Have not reviewed or tested yet.
Adding 2 new patches and interdiff that cover point two in the IS as well.
- last update
over 1 year ago Custom Commands Failed - Merge request !6428Issue #3392621: Use POST requests for fetching of ckeditor embedded media previews → (Open) created by s_leu
- First commit to issue fork.
s_leu → changed the visibility of the branch 3392621-ckeditor5-media-preview to hidden.
- Status changed to Needs review
about 1 year ago 2:38am 5 February 2024 Changed the IS to approach this from a different angle and filed a new corresponding MR including a test that fails without the other changes in from this MR.
- 🇺🇸United States smustgrave
Reading the steps why add an alt text with 20,000 characters?
Hey smustgrave, I know 20'000 is a lot but this is guaranteed to break things. The point is mainly that we shouldn't send something that could possibly a long string inside a GET parameter. This could already break on way less than 20'000 characters on some servers. See for example 💬 Extremely long Views AJAX query string triggers 403 in AWS Postponed: needs info .
- Status changed to Needs work
about 1 year ago 2:51pm 29 February 2024 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Yeah … I never saw this because this was filed against the component — thanks @smustgrave for moving this over 12 days ago! 👍
@s_leu: let's get this moving forward now! 😄💪
The point is mainly that we shouldn't send something that could possibly a long string inside a GET parameter.
That's fair.
Switching from
GETtoPOSTmakes the preview responses uncacheable in the browser. That's an unacceptable UX regression since this was introduced in #2994696: Render embedded media items in CKEditor → . So 📌 Make POST requests render cacheable Needs work won't help with that at all?It's not clear to me when in the real world you'd run into
GETquery string limitations. Because the data passed to the server via a query string is only the<drupal-media>tag plus its attributes.If we really must switch to a different mechanism to pass this data to the server, it MUST still result in a browser-cacheable response. The only alternative AFAICT is then a request header?
s_leu → changed the visibility of the branch 3392621-cke-media-preview-post-10.2.x to hidden.
s_leu → changed the visibility of the branch 3392621-cke-media-preview-post to hidden.
- Merge request !7811Issue #3392621: Send the editor markup of the media as base 64 encoded and... → (Open) created by s_leu
- 🇺🇸United States msielski
Re-rolling patch from #3 for 10.2.4 while work continues on this ticket.
- Status changed to Needs review
3 months ago 8:46pm 22 January 2025 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
