- Issue created by @andypost
- Status changed to Needs review
over 1 year ago 8:18pm 7 October 2023 - last update
over 1 year ago 30,382 pass - last update
over 1 year ago 30,380 pass, 1 fail The last submitted patch, 2: 3392396-2-fail.patch, failed testing. View results β
- π¬π§United Kingdom longwave UK
Should we ignore TrustedCallbackInterface when building the implementation array? If something implements that and one other unique interface it should probably also be considered for autowiring?
- Status changed to Needs work
over 1 year ago 10:56pm 7 October 2023 - last update
over 1 year ago 30,382 pass - Status changed to Needs review
over 1 year ago 12:21am 8 October 2023 - π«π·France andypost
https://symfony.com/blog/new-in-symfony-3-3-psr-4-based-service-discovery
When using a service definition prototype, if only one service is discovered that implements an interface, configuring the alias is not mandatory and Symfony will automatically create one.
So I extended test as no interface is registered automatically
- π¬π§United Kingdom joachim
π Enable more service autowiring by adding interface aliases to core modules Fixed should have got a CR, and the AutowireTest which it added needs much better failure messages, and docs, to explain how all this is meant to be done.
At the moment, adding a new service to core causes AutowireTest to fail and there's no clue at all of how to create services in a way that will satisfy it.
- Status changed to RTBC
over 1 year ago 5:11pm 12 October 2023 - last update
over 1 year ago 30,394 pass - π¬π§United Kingdom joachim
I've asked that π Enable more service autowiring by adding interface aliases to core modules Fixed be reopened.
- last update
over 1 year ago 30,397 pass - last update
over 1 year ago 30,412 pass - π¬π§United Kingdom longwave UK
π Improve the failure message from Drupal\KernelTests\Core\DependencyInjection\AutowireTest Active solves #8.
Committed and pushed 4cfa1b5ffb to 11.x and 6bdcb415f7 to 10.2.x. Thanks!
-
longwave β
committed 6bdcb415 on 10.2.x
Issue #3392396 by andypost, longwave: Improve AutowireTest to ignore...
-
longwave β
committed 6bdcb415 on 10.2.x
- Status changed to Fixed
over 1 year ago 9:42am 17 October 2023 -
longwave β
committed 4cfa1b5f on 11.x
Issue #3392396 by andypost, longwave: Improve AutowireTest to ignore...
-
longwave β
committed 4cfa1b5f on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.