- Issue created by @cedewey
- First commit to issue fork.
- last update
about 1 year ago 15 pass - Status changed to Needs review
about 1 year ago 11:02am 16 October 2023 - 🇮🇳India diwakar07
Hi, I have updated the Readme.MD file according to latest Drupal standards.
Please review. - last update
about 1 year ago 15 pass - Status changed to Needs work
about 1 year ago 12:51am 19 October 2023 - 🇺🇸United States cedewey Denver, CO
Hi Diwakar,
This is a great start towards the first step of formatting the text. We should create an actual help page that differs from the README.md file. For example, we don't need info about installing the module on the help page, since a user only sees this page after they've installed and enabled the module.
I think though we can keep these improvements you've made to the README.md file.
Next steps are to create a standalone help page and draft text geared towards sitebuilders explaining how to configure the module.
If you want to take a pass at that, feel free to! Otherwise I'll try and work on this in the next week or two.
- last update
about 1 year ago 15 pass - Assigned to diwakar07
- Status changed to Needs review
about 1 year ago 1:51pm 19 October 2023 - 🇮🇳India diwakar07
Hi, Thanks for the suggestions.
I have updated the help page accordingly. Adding the screenshots for the updated help page.
Please review. - Issue was unassigned.
- Status changed to Needs work
7 months ago 10:58am 31 May 2024 - 🇮🇳India manish-31
Hi @diwakar
Help page looks better now.
I got some trailing whitespaces warnings while applying the patch could you please fix those?
182: trailing whitespace. $output .= '<ol> 187: trailing whitespace. <li> Set permissions for commenting as per usual from 203: trailing whitespace. warning: 3 lines add whitespace errors.
Also, please consider below improvements
- Remove colons from paragraph headings.- Provide absolute URLs to the configuratin/permission pages.
- last update
7 months ago CI error - Status changed to Needs review
7 months ago 12:41pm 31 May 2024 - 🇮🇳India diwakar07
Hi,
I have updated the MR according to the review.
Please review. - Status changed to RTBC
5 months ago 8:08am 18 July 2024 - 🇮🇳India manish-31
The MR patch applies successfully without any warnings now.
Reviewed th Readme.md file has been updated as per the Readme.md standards.
Verified the help page contains all the necessary information and documentation links. Attaching Screenshot for reference.
Marking this RTBC.
Thanks!