Accessibility problems

Created on 5 October 2023, about 1 year ago
Updated 26 April 2024, 8 months ago

Problem/Motivation

There are a number of accessibility issues reported by https://validator.w3.org/nu:

1. Wrong heading structure - because of a hidden h2 coming from header blocks, etc.
2. Using of role attribute for header, main, footer and nav elements.

🐛 Bug report
Status

Fixed

Version

1.0

Component

BS Base

Created by

🇷🇸Serbia pivica

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @pivica
  • Status changed to Needs review about 1 year ago
  • 🇷🇸Serbia pivica

    Here is a patch.

  • Status changed to Needs work about 1 year ago
  • 🇷🇸Serbia pivica

    This will need a bit more work around language block support. Two problems there:

    1. Default language block is using div with a role="navigation". We should convert this to nav element.

    2. Dropdown implementation is using h6 for Language string. This is wrong and will break page outline structure. We need to convert this to regular label with aria-labelledby.

  • Status changed to Needs review about 1 year ago
  • 🇷🇸Serbia pivica

    New patch.

    > 1. Default language block is using div with a role="navigation". We should convert this to nav element.

    This is a bit dificult with current templates. Decided not to do it for now because this div role="navigation" should be the same as using nav element.

    > 2. Dropdown implementation is using h6 for Language string.

    This is fixed.

    Additionally for regular language block links (not dropdown) i've discovered additional html validation problems with using hreflang attribute on li instead on a element. This problems are coming from core and there is already a long standing issue for this in 🐛 Attribute hreflang not allowed on element li at this point Needs review . Applying just a code part patch from https://www.drupal.org/project/drupal/issues/2454289#comment-15225385 🐛 Attribute hreflang not allowed on element li at this point Needs review seems to fix this nicely.

  • 🇷🇸Serbia pivica

    Recompiled CSS.

    • pivica committed 5ab7af7c on 8.x-1.x
      Issue #3392074 by pivica: Accessibility problems
      
  • Status changed to Fixed 9 months ago
  • 🇷🇸Serbia pivica

    Committed.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024