- Issue created by @pivica
- Status changed to Needs review
about 1 year ago 11:15pm 5 October 2023 - Status changed to Needs work
about 1 year ago 1:06pm 6 October 2023 - 🇷🇸Serbia pivica
This will need a bit more work around language block support. Two problems there:
1. Default language block is using div with a role="navigation". We should convert this to nav element.
2. Dropdown implementation is using h6 for Language string. This is wrong and will break page outline structure. We need to convert this to regular label with aria-labelledby.
- Status changed to Needs review
about 1 year ago 9:02am 11 October 2023 - 🇷🇸Serbia pivica
New patch.
> 1. Default language block is using div with a role="navigation". We should convert this to nav element.
This is a bit dificult with current templates. Decided not to do it for now because this div role="navigation" should be the same as using nav element.
> 2. Dropdown implementation is using h6 for Language string.
This is fixed.
Additionally for regular language block links (not dropdown) i've discovered additional html validation problems with using hreflang attribute on li instead on a element. This problems are coming from core and there is already a long standing issue for this in 🐛 Attribute hreflang not allowed on element li at this point Needs review . Applying just a code part patch from https://www.drupal.org/project/drupal/issues/2454289#comment-15225385 🐛 Attribute hreflang not allowed on element li at this point Needs review seems to fix this nicely.
- Status changed to Fixed
9 months ago 2:02pm 12 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.