- Issue created by @barone
- Status changed to Needs review
about 1 year ago 8:21pm 5 October 2023 - Open on Drupal.org →Core: 10.1.x + Environment: PHP 8.1 & MySQL 8last update
about 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.x + Environment: PHP 8.1 & MySQL 8last update
about 1 year ago Waiting for branch to pass - 🇨🇭Switzerland OlivierG
Hi,
the patch does not work correctly cause the getMenuName function doesn't get the name you already defined as blank in the constructor.
So we have to change the getMenuName function in order to check menuName is not blank. - Open on Drupal.org →Core: 10.1.x + Environment: PHP 8.1 & MySQL 8last update
about 1 year ago Waiting for branch to pass - 🇧🇷Brazil barone Belo Horizonte
Hi @OliverG thanks for the replay and for the patch. I'm adding a conditional check to avoid getting the error of calling ->id() on NULL. If this one works for you we may get this issue closed!
- Open on Drupal.org →Core: 10.1.x + Environment: PHP 8.1 & MySQL 8last update
12 months ago Waiting for branch to pass - 🇬🇷Greece idimopoulos
I am making a slight change to check for the ID, not just the entity. The reason is that OG menu seems to break the layout builder which passes as context an entity without an ID.
- Open on Drupal.org →Core: 10.1.x + Environment: PHP 8.1 & MySQL 8last update
12 months ago Waiting for branch to pass - 🇵🇱Poland alorenc Wolsztyn, 🇵🇱
I think we need to combine checks from #4 and #5, check if entity and id is not empty
- Merge request !15Error: Typed property MenuName accessed before initialization → (Open) created by alorenc