- Issue created by @RoSk0
- 🇳🇿New Zealand RoSk0 Wellington
Crosslinking. Making the behaviour configurable might be an overkill if this feature is implemented IMHO.
- Status changed to Needs review
about 1 year ago 3:19am 16 October 2023 - last update
about 1 year ago 30,409 pass, 1 fail - 🇳🇿New Zealand RoSk0 Wellington
Implementation turn out to be quite simple - make that field required.
Let's see what the test bot thinks.
The last submitted patch, 3: 3392036-3.patch, failed testing. View results →
- last update
about 1 year ago 30,410 pass - 🇺🇸United States smustgrave
Tagging for maintainer input.
My thought is if we made this change it would make the process different from the node edit screen. And if we were to change it there would that make the Workflow Settings for default moderation state be obsolete? Just my 2 cents but will leave in review.
The Needs Review Queue Bot → tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- Status changed to Needs work
about 1 year ago 11:21pm 10 November 2023 - First commit to issue fork.
- Merge request !9714Issue #3392036 by rosk0: Force users to make an active choice on the content moderation widget → (Open) created by ericgsmith
- 🇳🇿New Zealand ericgsmith
@nod_ it wasn't clear what needs work here - was it the needs-review-queue-bot comment of needs an MR?
I've moved @rosk0's patch to an MR.
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- First commit to issue fork.
- 🇮🇳India KumudB Ahmedabad
I have completed the required changes for this feature. Initially, the 'Default moderation state' field was set as a required field; however, as per the final requirements, it does not need to be mandatory. I have reverted the code that enforced this, and an empty option has been added to the 'Default moderation state' dropdown in the Workflow Settings form to prompt users to make an active selection.
Please review the current changes in this branch, which now align with the updated requirements.
Patch file also attached.
- 🇮🇳India KumudB Ahmedabad
As shown in the attached recording, when creating a new workflow, the dropdown now defaults to the empty option, allowing users to actively choose the appropriate moderation state rather than defaulting automatically. This behavior aligns with the intended functionality.
Please review the code and recording for confirmation
- 🇺🇸United States smustgrave
All changes should be in the same MR. Looking at the current one it's missing test coverage