- Issue created by @pdureau
- @pdureau opened merge request.
- Assigned to Grimreaper
- Status changed to Needs review
about 1 year ago 9:24am 4 October 2023 - 🇫🇷France pdureau Paris
Hello Grimreaper, can we have a look on those 3 commits.
dropdown
https://git.drupalcode.org/project/ui_suite_bootstrap/-/merge_requests/1...
Straightforward. I have also removed the useless default filters on booleans.
alert
https://git.drupalcode.org/project/ui_suite_bootstrap/-/merge_requests/1...
Moved from ui_suite_bootstrap_preprocess_pattern_alert to ui_suite_bootstrap_preprocess_status_messages
Tested with styleguide → module, works and looks OK
I have also added this filter:
{{ message|add_class('alert-link') }}
It looks good even if the child HTML element is not a link anchor, so we can keep it.
navbar
https://git.drupalcode.org/project/ui_suite_bootstrap/-/merge_requests/1...
Straightforward.
I have also removed the now useless _ui_suite_bootstrap_add_class, _ui_suite_bootstrap_set_attribute & _ui_suite_bootstrap_is_numeric_array
nav_item
Can we discuss about the removal of Url objects? Url objects are not welcomed in the component templates. Do you think there is another place, earlier in the data flow, where we can transform the URL objects to primitives?
card & navbar_nav
I will keep the issue on my side and set it as "Postponed" because we will wait for:
- 📌 Bootstrap 5: Convert menu, breadcrumb and pagers to the links prop type Needs review
- ✨ Make the Twig loops safer Postponed
It will be nice to merge anyway, so I can create a new issue for postponed tasks instead. Let's decide.
- 🇫🇷France Grimreaper France 🇫🇷
As discussed for alert, let's add a little bit of CSS reproducing Bootstrap CSS but changing the selector.
- Assigned to pdureau
- Status changed to Needs work
about 1 year ago 1:03pm 5 October 2023 - 🇫🇷France Grimreaper France 🇫🇷
Current MR status ok for me for:
- alert
- dropdown
- navbar - 🇫🇷France pdureau Paris
I am working on nav_item. I will rebase your work first.
- Assigned to Grimreaper
- Status changed to Needs review
about 1 year ago 2:05pm 5 October 2023 - Assigned to pdureau
- Status changed to Needs work
about 1 year ago 3:54pm 5 October 2023 - 🇫🇷France Grimreaper France 🇫🇷
Review done :)
If you can just reply to the comments, I can update the code.
- Assigned to Grimreaper
- Status changed to Needs review
about 1 year ago 6:49pm 5 October 2023 - Assigned to pdureau
- 🇫🇷France Grimreaper France 🇫🇷
Ok for me.
I just need an answer to my comment https://git.drupalcode.org/project/ui_suite_bootstrap/-/merge_requests/1... :)
- Assigned to Grimreaper
-
Grimreaper →
committed b74cd908 on 5.0.x authored by
pdureau →
Issue #3391309 by pdureau, Grimreaper: Remove nav_item, alert, dropdown...
-
Grimreaper →
committed b74cd908 on 5.0.x authored by
pdureau →
- Issue was unassigned.
- Status changed to Fixed
about 1 year ago 12:47pm 7 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.