Bootstrap 5: Convert menu, breadcrumb and pagers to the links prop type

We are waiting for ✨ Add links setting type Needs review

https://www.drupal.org/project/ui_patterns_settings/releases/8.x-2.1 → is out!
We can resume work.

4 commits.

Please wait UI Patterns Settings 2.2 before merging

Convert dropdown & navbar to the links prop type →

I have replaced the crazy PreprocessPatternNavbarNav by a simpler PreprocessMenu

Now, the "decision" of having header, text, link and divider items is a mix between item structure (url? title?) and link_attributes class inside the component template itself.

PreprocessMenu is not overriding "items" but adding "preprocessed_items" so it is up to each presenter template to decide which variable they use. Example menu.html.twig:

{{ pattern('navbar_nav', {
  'items': preprocessed_items,
  'attributes': attributes.addClass(classes ?: ['menu', 'menu--' ~ menu_name|clean_class]),
  'variant': 'default'
}) }}

dropdown_item compoentn and button(s dropdown_item variant were removed.

Careful: because we are never sure if the links went to the preprocess or not, I have added this ugly condition:

{% set link_attributes = link_attributes.storage() is defined ? link_attributes : create_attribute(link_attributes) %}

I may create a Drupal Core issue about that.

Simplification of dropdown component →

A few simplifications which are now possible:

• Simpler variants list, so a cleaner management of buttons groups in the template (buttons group only when button split)
• button_color, button_type & button_size are merged into button_variant

Also, missing "button_url" was added (works only with button_split)

Convert breadcrumb to the links prop type →

Straightforward.

Convert pagination to the links prop type →

...

Caerful: not tested with entity_pager →

Test in progress with Entity Pager

TODO:
- Test split
- Test dropdown
- Test dropdown with menu links

No entity pager support. Its structure is too opinionated.

Dropdown ok now.

Need to test split in ✨ actions and dropbutton form elements Needs work .

There is a problem regarding #3345267-10: actions and dropbutton form elements → .

Discussed with @pdureau ok.

Waiting for a merge in ui_patterns_settings and a new release.

Automatically closed - issue fixed for 2 weeks with no activity.