- Issue created by @pdureau
- Assigned to Grimreaper
- Status changed to Needs review
almost 2 years ago 7:50pm 7 February 2023 - @grimreaper opened merge request.
- Merge request !50Issue #3338283: Bootstrap 5: dropdown is too complicated β (Closed) created by Grimreaper
- π«π·France Grimreaper France π«π·
I opened the new MR https://git.drupalcode.org/project/ui_suite_bootstrap/-/merge_requests/50, because previous one needed a rebase and to make the rebase easier I squashed the commits so to not lose the history, I pushed this squashed and rebased version on a new branch, so new MR.
- @grimreaper opened merge request.
-
Grimreaper β
committed f266253a on 5.0.x authored by
pdureau β
Issue #3338283 by Grimreaper, pdureau: Add brand field in navbar. Add...
-
Grimreaper β
committed f266253a on 5.0.x authored by
pdureau β
- Assigned to pdureau
- Status changed to Needs work
almost 2 years ago 3:48pm 13 February 2023 - π«π·France Grimreaper France π«π·
As discussed, MR 50 had not been tested on real usage with menus, and modules like https://www.drupal.org/project/menu_link_attributes β to allow to add classes/attributes on the link and/or on the wrapper.
Also, the nav pattern had been forgotten in the refactoring.
I tried to make it work, but it is too time consuming and I have side effects on side effects.
The main problems:
- in real menu links, "url" is a URL object which options contains the attributes that will be used on the a tag.
- also the route of the URL object can determine extra behavior like that will display a span and that will display a button.
- in real menu links, attributes is then for the link wrapper.
- not using the link() method bypass attributes put on the link. And do not use the link generator system of Drupal that can be altered.
- so I don't think the patterns should be done based on a structure easily manipulable in YAML preview structure but based on a "real" structure.I know there is the subject of removing PHP preprocess from themes, but I think here it is needed.
- π«π·France Grimreaper France π«π·
When updating β¨ Bootstrap 5 : Components > Toasts Fixed MR, I found out that
|default('true')
or|default(true)
was bad for ensuring boolean settings default value. Ok for false, but as false or null is evaluated the same way having|default(true)
force the setting value to true even when FALSE.The only pattern having that is the dropdown in:
{% set auto_close = auto_close|default('true') %}
- @pdureau opened merge request.
- Issue was unassigned.
- Status changed to Closed: outdated
over 1 year ago 10:20am 24 June 2023 - π«π·France pdureau Paris
We move here π Bootstrap 5: Convert menu, breadcrumb and pagers to the links prop type Needs review