Enable row tokens in title and subtitle

Created on 2 October 2023, 9 months ago
Updated 3 October 2023, 9 months ago

Problem/Motivation

Previously, the title and subtitle fields accepted global tokens (arguments); however, they were not able to get values from the first row. Let's enable getting values from the first row.

Feature request
Status

Fixed

Version

5.0

Component

Views integration

Created by

🇺🇸United States andileco

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @andileco
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
    last update 9 months ago
    10 pass
  • @andileco opened merge request.
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
    last update 9 months ago
    10 pass
  • Status changed to Fixed 9 months ago
  • Status changed to Needs work 9 months ago
  • 🇺🇸United States andileco

    Setting to "Needs work" based on the following warnings from a user on a separate ticket:

    Warning: Undefined property: Drupal\views\ViewExecutable::$row_index in Drupal\views\Plugin\views\field\FieldPluginBase->getRenderTokens() (line 1676 of /.../web/core/modules/views/src/Plugin/views/field/FieldPluginBase.php)
    
    #0 /.../web/core/includes/bootstrap.inc(164): _drupal_error_handler_real()
    #1 /.../web/core/modules/views/src/Plugin/views/field/FieldPluginBase.php(1676): _drupal_error_handler()
    #2 /.../web/modules/contrib/charts/src/Plugin/views/style/ChartsPluginStyleChart.php(249): Drupal\views\Plugin\views\field\FieldPluginBase->getRenderTokens()
    #3 /.../web/core/modules/views/src/Plugin/views/display/DisplayPluginBase.php(2181): Drupal\charts\Plugin\views\style\ChartsPluginStyleChart->render()
    #4 /.../web/core/modules/views/src/ViewExecutable.php(1548): Drupal\views\Plugin\views\display\DisplayPluginBase->render()
    #5 /.../web/core/modules/views/src/Plugin/views/display/Block.php(131): Drupal\views\ViewExecutable->render()
    #6 /.../web/core/modules/views/src/ViewExecutable.php(1645): Drupal\views\Plugin\views\display\Block->execute()
    #7 /.../web/core/modules/views/src/Element/View.php(81): Drupal\views\ViewExecutable->executeDisplay()
    #8 /.../web/core/modules/views/src/Plugin/Block/ViewsBlock.php(59): Drupal\views\Element\View::preRenderViewElement()
    #9 /.../web/core/modules/block/src/BlockViewBuilder.php(171): Drupal\views\Plugin\Block\ViewsBlock->build()
    #10 [internal function]: Drupal\block\BlockViewBuilder::preRender()
    #11 /.../web/core/lib/Drupal/Core/Security/DoTrustedCallbackTrait.php(111): call_user_func_array()
    #12 /.../web/core/lib/Drupal/Core/Render/Renderer.php(797): Drupal\Core\Render\Renderer->doTrustedCallback()
    #13 /.../web/core/lib/Drupal/Core/Render/Renderer.php(386): Drupal\Core\Render\Renderer->doCallback()
    #14 /.../web/core/lib/Drupal/Core/Render/Renderer.php(458): Drupal\Core\Render\Renderer->doRender()
    #15 /.../web/core/lib/Drupal/Core/Render/Renderer.php(204): Drupal\Core\Render\Renderer->doRender()
    #16 /.../web/core/lib/Drupal/Core/Template/TwigExtension.php(474): Drupal\Core\Render\Renderer->render()
    #17 /.../web/sites/default/files/php/twig/651c0bc09b20e_page.html.twig_Bj0cCTPxM3Kvxh3eeTDrIthXV/0tBGBRhPLTKTbSLBQ-iaTODXSrJhqchmvEpWkMAsCJU.php(2173): Drupal\Core\Template\TwigExtension->escapeFilter()
    #18 /.../vendor/twig/twig/src/Template.php(171): __TwigTemplate_8bb4493cca89f63aa869e403d397e0d5->block_main_content()
    #19 /.../web/sites/default/files/php/twig/651c0bc09b20e_page.html.twig_Bj0cCTPxM3Kvxh3eeTDrIthXV/0tBGBRhPLTKTbSLBQ-iaTODXSrJhqchmvEpWkMAsCJU.php(994): Twig\Template->displayBlock()
    #20 /.../vendor/twig/twig/src/Template.php(171): __TwigTemplate_8bb4493cca89f63aa869e403d397e0d5->block_page_container()
    #21 /.../web/sites/default/files/php/twig/651c0bc09b20e_page.html.twig_Bj0cCTPxM3Kvxh3eeTDrIthXV/0tBGBRhPLTKTbSLBQ-iaTODXSrJhqchmvEpWkMAsCJU.php(85): Twig\Template->displayBlock()
    #22 /.../vendor/twig/twig/src/Template.php(394): __TwigTemplate_8bb4493cca89f63aa869e403d397e0d5->doDisplay()
    #23 /.../vendor/twig/twig/src/Template.php(367): Twig\Template->displayWithErrorHandling()
    #24 /.../web/sites/default/files/php/twig/651c0bc09b20e_page.html.twig_N7MOEn78dPsjdt5Obhm0ox3Rr/ddlPsQINOUrW8uLOU551t1Ro7nz8AfGBat1oQUqo_4A.php(44): Twig\Template->display()
    #25 /.../vendor/twig/twig/src/Template.php(394): __TwigTemplate_dd3eb3dcbcd0ad2e187c0282080a3f01->doDisplay()
    #26 /.../vendor/twig/twig/src/Template.php(367): Twig\Template->displayWithErrorHandling()
    #27 /.../vendor/twig/twig/src/Template.php(379): Twig\Template->display()
    #28 /.../vendor/twig/twig/src/TemplateWrapper.php(40): Twig\Template->render()
    #29 /.../web/core/themes/engines/twig/twig.engine(53): Twig\TemplateWrapper->render()
    #30 /.../web/core/lib/Drupal/Core/Theme/ThemeManager.php(372): twig_render_template()
    #31 /.../web/core/lib/Drupal/Core/Render/Renderer.php(445): Drupal\Core\Theme\ThemeManager->render()
    #32 /.../web/core/lib/Drupal/Core/Render/Renderer.php(204): Drupal\Core\Render\Renderer->doRender()
    #33 /.../web/core/lib/Drupal/Core/Template/TwigExtension.php(474): Drupal\Core\Render\Renderer->render()
    #34 /.../web/sites/default/files/php/twig/651c0bc09b20e_html.html.twig_t0hPxfAOs6lsJjZy-bj6c8u_W/geEYRa2oQs9wQwnoywgEpljcbKdppb_OLeCKKLmsDcQ.php(86): Drupal\Core\Template\TwigExtension->escapeFilter()
    #35 /.../vendor/twig/twig/src/Template.php(394): __TwigTemplate_5cdb651213c06709c94622e516e2452a->doDisplay()
    #36 /.../vendor/twig/twig/src/Template.php(367): Twig\Template->displayWithErrorHandling()
    #37 /.../vendor/twig/twig/src/Template.php(379): Twig\Template->display()
    #38 /.../vendor/twig/twig/src/TemplateWrapper.php(40): Twig\Template->render()
    #39 /.../web/core/themes/engines/twig/twig.engine(53): Twig\TemplateWrapper->render()
    #40 /.../web/core/lib/Drupal/Core/Theme/ThemeManager.php(372): twig_render_template()
    #41 /.../web/core/lib/Drupal/Core/Render/Renderer.php(445): Drupal\Core\Theme\ThemeManager->render()
    #42 /.../web/core/lib/Drupal/Core/Render/Renderer.php(204): Drupal\Core\Render\Renderer->doRender()
    #43 /.../web/core/lib/Drupal/Core/Render/MainContent/HtmlRenderer.php(158): Drupal\Core\Render\Renderer->render()
    #44 /.../web/core/lib/Drupal/Core/Render/Renderer.php(592): Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}()
    #45 /.../web/core/lib/Drupal/Core/Render/MainContent/HtmlRenderer.php(159): Drupal\Core\Render\Renderer->executeInRenderContext()
    #46 /.../web/core/lib/Drupal/Core/EventSubscriber/MainContentViewSubscriber.php(90): Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse()
    #47 [internal function]: Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray()
    #48 /.../web/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php(111): call_user_func()
    #49 /.../vendor/symfony/http-kernel/HttpKernel.php(187): Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch()
    #50 /.../vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\Component\HttpKernel\HttpKernel->handleRaw()
    #51 /.../web/core/lib/Drupal/Core/StackMiddleware/Session.php(58): Symfony\Component\HttpKernel\HttpKernel->handle()
    #52 /.../web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle()
    #53 /.../web/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\Core\StackMiddleware\KernelPreHandle->handle()
    #54 /.../web/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass()
    #55 /.../web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\page_cache\StackMiddleware\PageCache->handle()
    #56 /.../web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle()
    #57 /.../web/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(51): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle()
    #58 /.../web/core/lib/Drupal/Core/DrupalKernel.php(704): Drupal\Core\StackMiddleware\StackedHttpKernel->handle()
    #59 /.../web/index.php(19): Drupal\Core\DrupalKernel->handle()
    #60 {main}
    
  • Status changed to Needs review 9 months ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
    last update 9 months ago
    10 pass
  • 🇺🇸United States andileco

    OK, I was able to replicate the warnings and this patch fixes for me.

  • 🇺🇸United States andileco

    Committed.

  • Status changed to Fixed 9 months ago
    • andileco committed c8e55ad1 on 5.0.x
      Issue #3391136 by andileco: Enable row tokens in title and subtitle
      
  • 🇦🇹Austria maxilein

    Thank you. Fixed it. D10.1

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024