- last update
over 1 year ago Composer require-dev failure - Issue created by @ahmadhalah
- Status changed to Needs work
over 1 year ago 6:29pm 30 September 2023 - πΊπΈUnited States smustgrave
Seems to have a lot of out of scope changes in the patch. Should be reworked to just include the requested changes.
- πΊπΈUnited States ahmadhalah
Hello @smustgrave, the other changes are related to code indentation and standards
- πΊπΈUnited States smustgrave
This project still needs a drupalCI ticket, which will address phpcs there.
Though indentation may not be a phpcs issue.
Should leave out of this issue. - Open on Drupal.org βCore: 10.1.x + Environment: PHP 8.2 & MySQL 8last update
over 1 year ago Not currently mergeable. - last update
over 1 year ago Build Successful - last update
over 1 year ago Build Successful - πΊπΈUnited States smustgrave
Moved to MR and addressed spacing issue.
Though we seem to have lost session_count message.
- Status changed to Postponed: needs info
about 1 year ago 7:16pm 1 March 2024 - πΊπΈUnited States smustgrave
For where the session_count fits into the suggested change.
-
smustgrave β
committed b462baec on 4.0.x
Issue #3390815 by ahmadhalah: Enhance description messages and log the...
-
smustgrave β
committed b462baec on 4.0.x
- Status changed to Fixed
10 months ago 5:21pm 17 June 2024 - πΊπΈUnited States smustgrave
So kept some of the updates but left others. But is an improvement.
Automatically closed - issue fixed for 2 weeks with no activity.
Hi,
I came across an error that seems to be caused by this feature.
TypeError: htmlspecialchars(): Argument #1 ($string) must be of type string, Drupal\Core\Field\FieldItemList given in htmlspecialchars() (line 437 of /var/www/front8/web/core/lib/Drupal/Component/Utility/Html.php)
The
$account->getAccount()->name
in event_log_track_auth_user_logout (line 93) returns a FieldItemList and the FormatableMarkup is trying to escape the value when rendering it.
We should use
getAccountName()
as for the 'ref_char' variable.
Here's a patch attached.
I don't know if i'm supposed to open a new issue for this, as this issue is closed. Let me know.