Improve README.md

Created on 29 September 2023, 9 months ago
Updated 11 January 2024, 6 months ago

This is a follow up of Facets integration Fixed .

The readme should mention the existence of the Facet process plugin.

Also the readme should mention the field settings.

Feature request
Status

Fixed

Version

1.0

Component

Documentation

Created by

🇳🇱Netherlands batigolix Utrecht

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @batigolix
  • Status changed to Needs review 9 months ago
  • 🇳🇱Netherlands batigolix Utrecht

    This can be reviewed

  • Status changed to Needs work 9 months ago
  • 🇵🇭Philippines kenyoOwen

    Hi batigolix

    I applied and reviewed your patch, but it doesn't follow the README.md template.
    In "Project name and introduction" there is no need to add "country" in the project page, only the [project page] text. As per README.md Bulleted lists denoted by dashes, maybe change the configuration to dashes (-). In the Configuration section the manage form display page I'm not sure if the readability is correct but I have a suggestion "you can choose if the country field is an autocomplete, a select list, a radio button, or a checkbox field.". And lastly the maintainer format is wrong, as per README.md the format should be - Daniel F. Kudwien - [sun](https://www.drupal.org/u/sun) and make sure the text is wrapped within around 80 cols.

    Thank you.

  • Status changed to Needs review 9 months ago
  • 🇮🇳India Shubh1306352

    Hii kenyoOwen,
    See my patch file , I have done changes according to your requirement .

  • Status changed to Needs work 9 months ago
  • 🇵🇭Philippines kenyoOwen

    Hi Shubh1306352

    Your patch failed to apply, kindly add a new patch with the changes. And as I read your patch it doesn't follow the README.md template.

    Thank you.

  • Status changed to Needs review 8 months ago
  • 🇳🇱Netherlands batigolix Utrecht

    This new patch addresses some of the points made in comment #3:

    I do not think all points are valid. Keep in mind that the patch should address what is mentioned in the issue description.

    I ignore the patch in #5 because it completely misses the point of this issue and is based on an old version?

  • Status changed to Needs work 8 months ago
  • 🇵🇭Philippines kenyoOwen

    Hi batigolix

    I applied and reviewed your patch #8 and noticed that your close bracket is duplicated in configuration section [your content type]] and also make your text word-wrapped within around 80 cols as per README.md template. For more information or a sample of README.md visit this link.

    Thank you.

  • Status changed to Needs review 7 months ago
  • 🇳🇱Netherlands batigolix Utrecht

    I fixed the bracket and line length.

  • Status changed to RTBC 7 months ago
  • 🇵🇭Philippines kenyoOwen

    Hi batigolix

    I applied and reviewed your patch #10 and confirmed that it resolved the issue.

    Thank you.

  • Status changed to Fixed 6 months ago
  • 🇳🇱Netherlands batigolix Utrecht
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024