- Issue created by @batigolix
- Status changed to Needs review
about 1 year ago 3:33pm 29 September 2023 - Status changed to Needs work
about 1 year ago 2:45am 2 October 2023 - 🇵🇭Philippines kenyoOwen
Hi batigolix
I applied and reviewed your patch, but it doesn't follow the README.md template.
In "Project name and introduction" there is no need to add "country" in the project page, only the [project page] text. As per README.md Bulleted lists denoted by dashes, maybe change the configuration to dashes (-). In the Configuration section the manage form display page I'm not sure if the readability is correct but I have a suggestion "you can choose if the country field is an autocomplete, a select list, a radio button, or a checkbox field.". And lastly the maintainer format is wrong, as per README.md the format should be- Daniel F. Kudwien - [sun](https://www.drupal.org/u/sun)
and make sure the text is wrapped within around 80 cols.Thank you.
- Status changed to Needs review
about 1 year ago 5:04am 3 October 2023 - 🇮🇳India Shubh1306352
Hii kenyoOwen,
See my patch file , I have done changes according to your requirement . - Status changed to Needs work
about 1 year ago 6:59am 5 October 2023 - 🇵🇭Philippines kenyoOwen
Hi Shubh1306352
Your patch failed to apply, kindly add a new patch with the changes. And as I read your patch it doesn't follow the README.md template. →
Thank you.
- Status changed to Needs review
about 1 year ago 8:17am 27 October 2023 - 🇳🇱Netherlands batigolix Utrecht
This new patch addresses some of the points made in comment #3:
I do not think all points are valid. Keep in mind that the patch should address what is mentioned in the issue description.
I ignore the patch in #5 because it completely misses the point of this issue and is based on an old version?
- Status changed to Needs work
about 1 year ago 6:39am 2 November 2023 - 🇵🇭Philippines kenyoOwen
Hi batigolix
I applied and reviewed your patch #8 and noticed that your close bracket is duplicated in configuration section
[your content type]]
and also make your text word-wrapped within around 80 cols as per README.md template. For more information or a sample of README.md visit this link. →Thank you.
- Status changed to Needs review
12 months ago 10:13am 24 November 2023 - Status changed to RTBC
12 months ago 1:54am 29 November 2023 - 🇵🇭Philippines kenyoOwen
Hi batigolix
I applied and reviewed your patch #10 and confirmed that it resolved the issue.
Thank you.
-
batigolix →
authored ebe52a76 on 8.x-1.x
Issue #3390684 by batigolix, kenyoOwen: Improve README.md
-
batigolix →
authored ebe52a76 on 8.x-1.x
- Status changed to Fixed
11 months ago 3:42pm 28 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.