Release 1.2.5 adds explicit dependency on google_analytics, causes WSOD on sites with cookies_ga enabled without google_analytics

Yeah, looks like this was a BC that needs a new major release!

I think we will need to revert this change and make the changes in 2.x. for people still using the deprecated ga module.

@Grevil: See 📌 Seriously consider respecting semantic versioning Active for reference

@Grevil: Perhaps another alternative would be to topic the cookies_ga submodule into cookies_google_analytics and revert the changes to cookies_ga afterwards. Then deprecate the cookies_ga submodule (by text) and tell people they just need to enable cookies_google_analytics instead?

I think that might be the cleanest way?

@Anybody, let us simply create a proper update hook, telling the user to switch to google_analytics. The other approach might be a bit too much.

@Grevil: So the plan is to uninstall cookies_ga if google_analytics module is not enabled? Plus warn the user and give them the option to downgrade to 1.2.4 otherwise?

Reason: ga module has no supported release anymore?

Sth. like: IMPORTANT: The Googalytics (ga) module is unsupported and for that reason also unsupported by COOKiES. Please consider switching to Google Analytics (google_analytics) module ASAP. If you proceed, the cookies_ga submodule will be uninstalled, as otherwise you run into <a href="https://www.drupal.org/project/cookies/issues/3390680">this issue</a>. Googalytics (ga) will not be Cookie-protected anymore! To keep support for Googalytics (ga) downgrade to COOKiES <= 1.2.4 as temporary fix.

Yea, sounds good! Update hook works great! Please review!

Once minor change.

I'm fine with that!

Ok ready for review now.

Please tag a new release :)

Thank you @Grevil and @Anybody for fixing this so quickly :)

/A

Automatically closed - issue fixed for 2 weeks with no activity.