Contrib.social

Optionally allow specifying the button icon for use in the admin UI in the ckeditor5 plugin definition

Open on Drupal.org →
Created on 29 September 2023, 11 months ago
Updated 3 October 2023, 11 months ago

Problem/Motivation

When creating a ckeditor5 plugin, there's no easy way of defining an icon for the toolbar button, it has to be added via a custom CSS file loaded via a custom library.

Proposed resolution

Add an attribute to the ckeditor5 plugin definition for listing the icon.

Remaining tasks

Work out how to do this.
Do this.
Test coverage.

User interface changes

n/a

API changes

TBD

Data model changes

n/a

Release notes snippet

TBD

✨ Feature request
Status

Active

Version

11.0 🔥

Component
CKEditor 5  →

Last updated 2 days ago

Created by

🇺🇸United States DamienMcKenna NH, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @DamienMcKenna
  • Comment 11 months ago →
    🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺

    I agree it's rather complicated. But it's also flexible, because not all CKEditor 5 toolbar items are simply a button with an icon.

    IOW: this could be a nice DX improvement indeed.

    IIRC @zrpnr, @bnjmnm and @lauriii settled on this approach. I'd like to hear from them 😊

  • Comment 11 months ago →
    🇺🇸United States DamienMcKenna NH, USA

    While not all toolbar buttons have a simple button with an icon, I'd wager a notable majority do. So from a DX perspective this should be easier.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024