- Issue created by @mondrake
- last update
over 1 year ago Custom Commands Failed - @mondrake opened merge request.
- last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - Status changed to Postponed
over 1 year ago 1:07pm 28 September 2023 - ๐ฎ๐นItaly mondrake ๐ฎ๐น
This detects more than we need :(
I think this is not usable until https://github.com/ekino/phpstan-banned-code/issues/60 is solved upstream... using
exit
andecho
is legit in some of Drupal code and the error thrown can't be disabled. - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - Status changed to Needs review
over 1 year ago 3:16pm 28 September 2023 - ๐ฎ๐นItaly mondrake ๐ฎ๐น
Actually with just 1 ignoreErrors entry added to
phpstan.neon.dist
we can make it do exactly what we need for now. - Status changed to Needs work
over 1 year ago 11:26pm 28 September 2023 - ๐บ๐ธUnited States smustgrave
Seemed to have a CC failure. Tagging for framework manager to make the call too.
- Status changed to Needs review
over 1 year ago 4:48am 29 September 2023 - ๐ฎ๐นItaly mondrake ๐ฎ๐น
Actually, the failure is what I would like to be reviewed and commentedโฆ
- ๐ง๐ชBelgium borisson_ Mechelen, ๐ง๐ช
If we want to use this, we should probably do a dependency evaluation as well?
I think this is a good solution to ensure that we no longer use some of those unwanted functions, but I'm not sure that this phpstan plugin is the right solution, it looks like it contains some rules we don't want to (or can't) use in core itself. - ๐ฎ๐นItaly mondrake ๐ฎ๐น
I'm not sure that this phpstan plugin is the right solution, it looks like it contains some rules we don't want to (or can't) use in core itself.
that's why I'd suggest to ignore those that we do not need.
Actually, mglaman/phpstan-drupal is implemented exactly with this model - it has some opinionated rules that we are just ignoring,
# Ignore common errors for now. - "#Drupal calls should be avoided in classes, use dependency injection instead#" - "#^Plugin definitions cannot be altered.#" - "#^Missing cache backend declaration for performance.#"
- ๐บ๐ธUnited States smustgrave
I for one kinda like the idea of being able to prevent certain functions from coming back. But not sure the process for adding a package takes. Would think if we pursue that all functions should be allowed and we 1 by 1 remove any we want.
- Status changed to Needs work
about 1 year ago 1:52pm 17 October 2023 The Needs Review Queue Bot โ tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- Status changed to Closed: won't fix
2 months ago 8:24pm 21 October 2024