Call to a member function id() on null in ScheduledTransitionsRunner->transitionEntity()

Should fix it. newState should never be null right? after all, this is scheduled transitions, not scheduled binary state.

The last submitted patch, 4: 3390291-04.patch, failed testing. View results →

ok patch 4 is for 2.3.x - it's good, passes D9.5 tests as expected.

patch 8 is for 2.4.x - Running tests

This fix might not be the optimal solution but for now it's all I've got.
root cause could be something a bit strange situation like a workflow that was removed.

Upgrade from 2.2.x to 2.3.0, run cron then check your logs

This doesnt seem right. Perhaps a workflow was modified, deleting a state.

By the look an invalid $newState = NULL seems to have been possible since the inception of the project (2018).

--

Please use MRs, not patches.

Lets use === NULL.

Tests should be straightforward: Provide a non-existent state machine name with all the normal set up (inspiration from existing tests)

I have updated for this issue: Call to a member function id() on null in ScheduledTransitionsRunner->transitionEntity()

14 doesnt answer or address the points from 12.

The automated tests depend on the core function "createEditorialWorkflow()"

To test this one would have to create a new workflow called bogus_workflow();

Example:

    $workflow = Workflow::create([
      'id' => 'bogus_workflow',
      'label' => 'REST Workflow',
      'type' => 'workflow_type_complex_test',
    ]);
    $workflow
      ->getTypePlugin()
      ->addState('draft', 'Draft')
      ->addState('published', 'Published');
    $configuration = $workflow->getTypePlugin()->getConfiguration();
    $configuration['example_setting'] = 'foo';
    $configuration['states']['draft']['extra'] = 'bar';
    $workflow->getTypePlugin()->setConfiguration($configuration);
    $workflow->save();

then with a newly created content , assign a transition from the bogus_workflow

Then delete the bogus_workflow

$workflow->delete();

Then run cron

BOOM!

This will prove that the above patch works.