- Issue created by @Delty
- Assigned to Grevil
- 🇩🇪Germany Anybody Porta Westfalica
Thanks for the report! @Grevil could you take a kind look?
Seems this caused a regression: 📌 Compatibility with Drupal 10 Fixed
- Assigned to abhishek_virasat
- 🇩🇪Germany Anybody Porta Westfalica
@abhishek_virasat WTF! If a task is assigned to someone else, explicitly STOP assigning it to you! Of course you may help to resolve a task, but then help first and kindly ask, if your solution is good enough to take over!
I'm fed up with this messy behaviour!! - Assigned to Grevil
- last update
about 1 year ago 2 fail - @abhishek_virasat opened merge request.
- 🇩🇪Germany Grevil
Yea my apologies... No idea, why I swapped out "$menu_names = menu_ui_get_menus();" with "$menu_names = Menu::loadMultiple();".
"Menu::loadMultiple" explicitly loads menu objects, but we simply want menu names here... see here: https://www.drupal.org/node/3027453 → on how to properly refactor it.
- 🇩🇪Germany Grevil
Changes by @abhishek_virasat are incorrect and don't make sense in this context. Therefore, I'll remove the credit.
- last update
about 1 year ago 2 fail - @anybody opened merge request.
- last update
about 1 year ago 2 fail - Status changed to Needs review
about 1 year ago 8:47am 28 September 2023 - 🇩🇪Germany Grevil
Alright, all done! I also found another bug where when there is no shop configured, "$form['actions']" is NULL and executing "array_keys($form['actions'])" will throw an error, when trying to add a product.
Please review!
- 🇩🇪Germany Grevil
No idea, what's up with the tests... apparently "commerce" isn't required by composer for the tests... no idea why.
- Status changed to RTBC
about 1 year ago 8:51am 28 September 2023 - 🇩🇪Germany Anybody Porta Westfalica
Thank you very much @Grevil!
Could you please tag a new stable release?
I guess the failing tests are due to the fork? Please re-check in main, once merged.
- last update
about 1 year ago 2 fail - last update
about 1 year ago 2 fail - Status changed to Fixed
about 1 year ago 8:53am 28 September 2023 - 🇩🇪Germany Grevil
Could you please tag a new stable release?
Yes I will!
I guess the failing tests are due to the fork? Please re-check in main, once merged.
Probably so, I will!
- 🇺🇸United States Delty
Thanks all y'all - the speedy response and patch is much appreciated!
-=Delty
Automatically closed - issue fixed for 2 weeks with no activity.