[1.0.x] Twicpics

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,>DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status will not be changed by this application; no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the branch to review and the project name.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications, even to leave a comment similar to the following one. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• It is also preferable to wait before using a CLI tool → to report what needs to be changed, especially because the comment left from Code Review Administrators suggests to use PHP_CodeSniffer. Before that, manual reviews should be done.
• Reviewers should not copy-paste the output of a CLI tool. They should use a CLI tool only once per application. When they do that, they should later verify the code has been correctly changed; this means, for example, that adding a documentation comment that is not correct just to avoid to get a warning/error is not a correct change that should be reported in a further comment.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

Fix phpcs issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml twicpics/

FILE: twicpics/twicpics.info.yml                                                         
---------------------------------------------------------------------- 
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE                                                              
---------------------------------------------------------------------- 
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically 
---------------------------------------------------------------------- 
                                                                                                           
                                                                                                           
FILE: twicpics/README.md                                                                 
----------------------------------------------------------------------                                     
FOUND 0 ERRORS AND 14 WARNINGS AFFECTING 14 LINES                                                          
----------------------------------------------------------------------                                     
  7 | WARNING | Line exceeds 80 characters; contains 203 characters                                        
  9 | WARNING | Line exceeds 80 characters; contains 273 characters                                        
 14 | WARNING | Line exceeds 80 characters; contains 120 characters
 16 | WARNING | Line exceeds 80 characters; contains 197 characters
 22 | WARNING | Line exceeds 80 characters; contains 87 characters
 30 | WARNING | Line exceeds 80 characters; contains 84 characters
 31 | WARNING | Line exceeds 80 characters; contains 99 characters
 32 | WARNING | Line exceeds 80 characters; contains 160 characters
 47 | WARNING | Line exceeds 80 characters; contains 154 characters
 51 | WARNING | Line exceeds 80 characters; contains 83 characters
 52 | WARNING | Line exceeds 80 characters; contains 148 characters
 54 | WARNING | Line exceeds 80 characters; contains 128 characters
 55 | WARNING | Line exceeds 80 characters; contains 101 characters
 56 | WARNING | Line exceeds 80 characters; contains 170 characters
----------------------------------------------------------------------


FILE: twicpics/twicpics.module
---------------------------------------------------------------------- 
FOUND 98 ERRORS AND 15 WARNINGS AFFECTING 80 LINES
---------------------------------------------------------------------- 
   9 | WARNING | [x] Unused use statement
   9 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Render\Element.
   9 | ERROR   | [x] When importing a class with "use", do not include a leading \
  11 | WARNING | [ ] All constants defined by a module must be prefixed with the module's name, expected "TWICPICS_R_PUBLIC_PATH" but found "R_PUBLIC_PATH"
  11 | WARNING | [ ] Global constants should not be used, move it to a class or interface
  11 | ERROR   | [x] Expected 1 space before "="; 0 found
  11 | ERROR   | [x] Expected 1 space after "="; 0 found
  12 | WARNING | [ ] All constants defined by a module must be prefixed with the module's name, expected "TWICPICS_R_STYLE" but found "R_STYLE"
  12 | WARNING | [ ] Global constants should not be used, move it to a class or interface
  12 | ERROR   | [x] Expected 1 space before "="; 0 found
  12 | ERROR   | [x] Expected 1 space after "="; 0 found
  13 | WARNING | [ ] All constants defined by a module must be prefixed with the module's name, expected "TWICPICS_ASSET" but found "ASSET"
  13 | WARNING | [ ] Global constants should not be used, move it to a class or interface
  13 | ERROR   | [x] Expected 1 space before "="; 0 found
  14 | WARNING | [ ] All constants defined by a module must be prefixed with the module's name, expected "TWICPICS_BASE" but found "BASE"
  14 | WARNING | [ ] Global constants should not be used, move it to a class or interface
  15 | WARNING | [ ] All constants defined by a module must be prefixed with the module's name, expected "TWICPICS_EXTENSION" but found "EXTENSION"
  15 | WARNING | [ ] Global constants should not be used, move it to a class or interface
  15 | ERROR   | [x] Expected 1 space before "="; 0 found
  16 | WARNING | [ ] All constants defined by a module must be prefixed with the module's name, expected "TWICPICS_STYLE_ID" but found "STYLE_ID"
  16 | WARNING | [ ] Global constants should not be used, move it to a class or interface
  19 | ERROR   | [ ] More than 2 empty lines are not allowed
  20 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found 2
  23 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found 2
  23 | ERROR   | [x] Expected 1 blank line before function; 3 found
  24 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  25 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  26 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  27 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 8
  28 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 8
  29 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 8
  30 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 8
  31 | ERROR   | [x] Case breaking statements must be followed by a single blank line
  32 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  33 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  34 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found 2
  36 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found 2
  39 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found 2
  40 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  41 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  42 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  43 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  43 | ERROR   | [x] Expected 1 space after IF keyword; 0 found
  44 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  46 | ERROR   | [x] Concat operator must be surrounded by a single space
  46 | ERROR   | [x] Concat operator must be surrounded by a single space
  48 | ERROR   | [x] Expected 1 space after "=>"; 2 found
  50 | WARNING | [x] A comma should follow the last multiline array item. Found: TRUE
  51 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
  55 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  56 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  57 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found 2
  59 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found 2
  62 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found 2
  63 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  64 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  64 | ERROR   | [x] Expected 1 space after IF keyword; 0 found
  65 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  66 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  67 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  68 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found 2
  70 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found 2
  73 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found 2
  74 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  76 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  77 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  78 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  79 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  80 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  82 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  84 | ERROR   | [x] There should be no white space after an opening "("
  84 | ERROR   | [x] Whitespace found at end of line
  86 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 8
  86 | ERROR   | [x] Inline comments must start with a capital letter
  86 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
  87 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 8
  87 | ERROR   | [x] There should be no white space after an opening "("
  87 | ERROR   | [x] There should be no white space before a closing ")"
  90 | ERROR   | [x] Whitespace found at end of line
  92 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  92 | ERROR   | [x] Inline comments must start with a capital letter
  93 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  96 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  96 | ERROR   | [x] Inline comments must start with a capital letter
  96 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
  97 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  97 | ERROR   | [x] Expected 1 space before "="; 0 found
  98 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  98 | ERROR   | [x] Inline comments must start with a capital letter
  98 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
  99 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  99 | ERROR   | [x] Expected 1 space before "="; 0 found
  99 | ERROR   | [x] Concat operator must be surrounded by a single space
 100 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 102 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 103 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 10
 104 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 10
 104 | ERROR   | [x] No space found before comment text; expected "// Get possible style conversion with twicpics api" but found "//Get possible style conversion with   
     |         |     twicpics api"
 104 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 105 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 10
 106 | ERROR   | [x] Space found after object operator
 107 | ERROR   | [x] Space found after object operator
 110 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 10
 111 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 113 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 115 | ERROR   | [x] Concat operator must be surrounded by a single space
 116 | ERROR   | [x] Concat operator must be surrounded by a single space
 119 | ERROR   | [x] Concat operator must be surrounded by a single space
 120 | ERROR   | [x] Concat operator must be surrounded by a single space
 121 | ERROR   | [x] Concat operator must be surrounded by a single space
 123 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
 124 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 125 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found 2
---------------------------------------------------------------------- 
PHPCBF CAN FIX THE 100 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------- 


FILE: twicpics/src/Form/TwicpicsForm.php
---------------------------------------------------------------------- 
FOUND 29 ERRORS AND 13 WARNINGS AFFECTING 38 LINES
---------------------------------------------------------------------- 
   8 | ERROR   | [x] Missing class doc comment
  10 | ERROR   | [ ] Missing member variable doc comment
  11 | ERROR   | [ ] Missing member variable doc comment
  11 | ERROR   | [x] Whitespace found at end of line
  13 | ERROR   | [x] Missing function doc comment
  15 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
  18 | ERROR   | [x] Missing function doc comment
  22 | ERROR   | [x] Expected newline after closing brace
  27 | ERROR   | [x] Missing function doc comment
  31 | ERROR   | [x] Expected newline after closing brace
  41 | ERROR   | [x] Expected 1 blank line after function; 2 found
  59 | WARNING | [ ] Unused variable $class.
  61 | ERROR   | [x] Short array syntax must be used to define arrays
  62 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8
  63 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8
  64 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8
  64 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  65 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8
  65 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  66 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8
  67 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8
  68 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8
  69 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8
  75 | ERROR   | [x] Expected newline after closing brace
  82 | ERROR   | [x] Short array syntax must be used to define arrays
  85 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  87 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  92 | ERROR   | [x] Short array syntax must be used to define arrays
  95 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  97 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 102 | ERROR   | [x] Short array syntax must be used to define arrays
 105 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 107 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 112 | ERROR   | [x] Short array syntax must be used to define arrays
 115 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 117 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 122 | ERROR   | [x] Short array syntax must be used to define arrays
 125 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 127 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
 127 | ERROR   | [x] Expected 1 space after "!=="; 0 found
 134 | ERROR   | [x] Short array syntax must be used to define arrays
 137 | WARNING | [x] A comma should follow the last multiline array item. Found: 'primary'
---------------------------------------------------------------------- 
PHPCBF CAN FIX THE 28 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------- 


FILE: twicpics/src/Service/Compute.php
---------------------------------------------------------------------- 
FOUND 19 ERRORS AFFECTING 7 LINES
---------------------------------------------------------------------- 
  5 | ERROR | [x] Missing class doc comment
  7 | ERROR | [x] Missing function doc comment
  8 | ERROR | [x] There should be no white space after an opening "("
  8 | ERROR | [x] There should be no white space after an opening "("
  8 | ERROR | [x] There should be no white space before a closing ")"
  8 | ERROR | [x] There should be no white space after an opening "("
  8 | ERROR | [x] There should be no white space before a closing ")"
  8 | ERROR | [x] There should be no white space before a closing ")"
 10 | ERROR | [x] Expected newline after closing brace
 11 | ERROR | [x] There should be no white space after an opening "("
 11 | ERROR | [x] There should be no white space after an opening "("
 11 | ERROR | [x] There should be no white space before a closing ")"
 11 | ERROR | [x] There should be no white space before a closing ")"
 13 | ERROR | [x] There should be no white space after an opening "("
 13 | ERROR | [x] There should be no white space after an opening "("
 13 | ERROR | [x] There should be no white space before a closing ")"
 13 | ERROR | [x] There should be no white space before a closing ")"
 21 | ERROR | [x] Expected 1 newline at end of file; 0 found
 21 | ERROR | [x] The closing brace for the class must have an empty line before it
---------------------------------------------------------------------- 
PHPCBF CAN FIX THE 19 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------- 


FILE: twicpics/src/Service/MappingImageStyle.php
---------------------------------------------------------------------- 
FOUND 117 ERRORS AND 6 WARNINGS AFFECTING 56 LINES
---------------------------------------------------------------------- 
  10 | ERROR   | [ ] Missing member variable doc comment
  19 | WARNING | [x] A comma should follow the last multiline array item. Found: "rotate"
  22 | ERROR   | [ ] Missing member variable doc comment
  34 | ERROR   | [ ] Missing member variable doc comment
  47 | ERROR   | [x] Expected 0 spaces after opening parenthesis; 1 found
  47 | ERROR   | [x] There should be no white space after an opening "("
  47 | ERROR   | [x] There should be no white space before a closing ")"
  47 | ERROR   | [x] Expected 0 spaces before closing parenthesis; 1 found
  51 | ERROR   | [x] Expected 1 space after FOREACH keyword; 0 found
  51 | ERROR   | [x] There should be no white space after an opening "("
  51 | ERROR   | [x] There should be no white space before a closing ")"
  53 | ERROR   | [x] There should be no white space after an opening "("
  53 | ERROR   | [x] There should be no white space after an opening "("
  53 | ERROR   | [x] There should be no white space before a closing ")"
  53 | ERROR   | [x] There should be no white space before a closing ")"
  56 | ERROR   | [x] There should be no white space after an opening "("
  56 | ERROR   | [x] There should be no white space before a closing ")"
  66 | ERROR   | [x] There should be no white space after an opening "("
  66 | ERROR   | [x] There should be no white space before a closing ")"
  67 | ERROR   | [x] Expected 1 space before ":"; 0 found
  70 | ERROR   | [x] No space found before comment text; expected "// Focus" but found "//Focus"
  70 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
  72 | ERROR   | [x] There should be no white space after an opening "("
  72 | ERROR   | [x] There should be no white space before a closing ")"
  72 | ERROR   | [x] Whitespace found at end of line
  73 | ERROR   | [x] There should be no white space after an opening "("
  73 | ERROR   | [x] There should be no white space before a closing ")"
  75 | ERROR   | [x] Concat operator must be surrounded by a single space
  75 | ERROR   | [x] Space found after square bracket; expected "[$drupalData" but found "[ $drupalData"
  75 | ERROR   | [x] Space found after square bracket; expected "['anchor'" but found "[ 'anchor'"
  75 | ERROR   | [x] Space found before square bracket; expected "'anchor']" but found "'anchor' ]"
  75 | ERROR   | [x] Space found before square bracket; expected "]]" but found "] ]"
  77 | ERROR   | [x] Whitespace found at end of line
  78 | ERROR   | [x] No space found before comment text; expected "// Scale Effect" but found "//Scale Effect"
  78 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
  79 | ERROR   | [x] There should be no white space after an opening "("
  79 | ERROR   | [x] There should be no white space before a closing ")"
  80 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
  80 | ERROR   | [x] There should be no white space after an opening "("
  80 | ERROR   | [x] There should be no white space before a closing ")"
  82 | ERROR   | [x] Space found after square bracket; expected "['width'" but found "[ 'width'"
  82 | ERROR   | [x] Space found before square bracket; expected "'width']" but found "'width' ]"
  83 | ERROR   | [x] Space found after square bracket; expected "['height'" but found "[ 'height'"
  83 | ERROR   | [x] Space found before square bracket; expected "'height']" but found "'height' ]"
  83 | ERROR   | [x] Whitespace found at end of line
  86 | ERROR   | [x] There should be no white space after an opening "("
  86 | ERROR   | [x] There should be no white space before a closing ")"
  87 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
  87 | ERROR   | [x] There should be no white space after an opening "("
  87 | ERROR   | [x] There should be no white space before a closing ")"
  89 | ERROR   | [x] Space found after square bracket; expected "['width'" but found "[ 'width'"
  89 | ERROR   | [x] Space found before square bracket; expected "'width']" but found "'width' ]"
  90 | ERROR   | [x] Space found after square bracket; expected "['height'" but found "[ 'height'"
  90 | ERROR   | [x] Space found before square bracket; expected "'height']" but found "'height' ]"
  90 | ERROR   | [x] Whitespace found at end of line
  95 | ERROR   | [x] No space found before comment text; expected "// Convert Effect" but found "//Convert Effect"
  95 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
  96 | ERROR   | [x] There should be no white space after an opening "("
  96 | ERROR   | [x] There should be no white space before a closing ")"
  97 | ERROR   | [x] There should be no white space after an opening "("
  97 | ERROR   | [x] Space found after square bracket; expected "['#markup'" but found "[ '#markup'"
  97 | ERROR   | [x] Space found before square bracket; expected "'#markup']" but found "'#markup' ]"
  97 | ERROR   | [x] There should be no white space before a closing ")"
  98 | ERROR   | [x] There should be no white space after an opening "("
  98 | ERROR   | [x] There should be no white space after an opening "("
  98 | ERROR   | [x] There should be no white space before a closing ")"
  98 | ERROR   | [x] There should be no white space before a closing ")"
  99 | ERROR   | [x] Concat operator must be surrounded by a single space
  99 | ERROR   | [x] Space found after square bracket; expected "[$drupalMarkup" but found "[ $drupalMarkup"
  99 | ERROR   | [x] Space found before square bracket; expected "$drupalMarkup]" but found "$drupalMarkup ]"
 103 | ERROR   | [x] No space found before comment text; expected "// Cover Effect" but found "//Cover Effect"
 103 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 104 | ERROR   | [x] There should be no white space after an opening "("
 104 | ERROR   | [x] There should be no white space before a closing ")"
 105 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 105 | ERROR   | [x] There should be no white space after an opening "("
 105 | ERROR   | [x] There should be no white space before a closing ")"
 107 | ERROR   | [x] Space found after square bracket; expected "['width'" but found "[ 'width'"
 107 | ERROR   | [x] Space found before square bracket; expected "'width']" but found "'width' ]"
 108 | ERROR   | [x] Space found after square bracket; expected "['height'" but found "[ 'height'"
 108 | ERROR   | [x] Space found before square bracket; expected "'height']" but found "'height' ]"
 108 | ERROR   | [x] Whitespace found at end of line
 112 | ERROR   | [x] No space found before comment text; expected "// Crop Effect" but found "//Crop Effect"
 112 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 113 | ERROR   | [x] There should be no white space after an opening "("
 113 | ERROR   | [x] There should be no white space after an opening "("
 113 | ERROR   | [x] There should be no white space before a closing ")"
 113 | ERROR   | [x] There should be no white space before a closing ")"
 114 | ERROR   | [x] Line indented incorrectly; expected 12 spaces, found 14
 114 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 114 | ERROR   | [x] There should be no white space after an opening "("
 114 | ERROR   | [x] There should be no white space before a closing ")"
 116 | ERROR   | [x] Space found after square bracket; expected "['width'" but found "[ 'width'"
 116 | ERROR   | [x] Space found before square bracket; expected "'width']" but found "'width' ]"
 117 | ERROR   | [x] Space found after square bracket; expected "['height'" but found "[ 'height'"
 117 | ERROR   | [x] Space found before square bracket; expected "'height']" but found "'height' ]"
 117 | ERROR   | [x] Whitespace found at end of line
 121 | ERROR   | [x] No space found before comment text; expected "// Resize Effect" but found "//Resize Effect"
 121 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 123 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 123 | ERROR   | [x] There should be no white space after an opening "("
 123 | ERROR   | [x] There should be no white space before a closing ")"
 125 | ERROR   | [x] Space found after square bracket; expected "['width'" but found "[ 'width'"
 125 | ERROR   | [x] Space found before square bracket; expected "'width']" but found "'width' ]"
 126 | ERROR   | [x] Space found after square bracket; expected "['height'" but found "[ 'height'"
 126 | ERROR   | [x] Space found before square bracket; expected "'height']" but found "'height' ]"
 126 | ERROR   | [x] Whitespace found at end of line
 130 | ERROR   | [x] No space found before comment text; expected "// Rotate Effect" but found "//Rotate Effect"
 130 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 131 | ERROR   | [x] There should be no white space after an opening "("
 131 | ERROR   | [x] There should be no white space before a closing ")"
 132 | ERROR   | [x] Line indented incorrectly; expected 12 spaces, found 14
 132 | ERROR   | [x] Concat operator must be surrounded by a single space
 139 | ERROR   | [x] Expected 1 space before ".="; 0 found
 140 | ERROR   | [x] Concat operator must be surrounded by a single space
 141 | ERROR   | [x] Concat operator must be surrounded by a single space
 142 | ERROR   | [x] Concat operator must be surrounded by a single space
 143 | ERROR   | [x] Concat operator must be surrounded by a single space
 144 | ERROR   | [x] Concat operator must be surrounded by a single space
 145 | ERROR   | [x] Concat operator must be surrounded by a single space
 146 | ERROR   | [x] Concat operator must be surrounded by a single space
 152 | ERROR   | [x] Expected 1 blank line after function; 0 found
 153 | ERROR   | [x] The closing brace for the class must have an empty line before it
---------------------------------------------------------------------- 
PHPCBF CAN FIX THE 115 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------- 

For these applications, we need a project where, in at least the branch used for the application, most of the commits (if not all the commits) have been done from the person who applies.
The purpose of these applications is reviewing a project to understand what the person who applies understands about writing secure code that follows the Drupal coding standards and correctly uses the Drupal API, not to understand what the project maintainers as group understand about those topics.

This application can only continue with another project where most of the commits (and preferable all the commits) have been done by s.leduc.

@vishal.kadam The point of my first comment is exactly this: Avoiding any review before a Code Review Administrator has done some checks.
See also the part about copy-pasting a PHP_CodeSniffer report to say what needs to be changed. Applicants need reviews from people who use their expertise to say what needs to be change, not from a tool that is not able to catch everything that needs to be changed without giving false positive.

phpcs error corrected

See my previous comment ( #4 → ).

Hello Apaderno,
I don't understand what you are wating for ?
I am the maintener and the main developper of this module. Most of the commits ( not all) have been done by me on this branch.
Can you specify what you expect?

For these applications, we need a project where, in at least the branch used for the application, most of the commits (if not all the commits) have been done from the person who applies.
The purpose of these applications is reviewing a project to understand what the person who applies understands about writing secure code that follows the Drupal coding standards and correctly uses the Drupal API, not to understand what the project maintainers as group understand about those topics.

This application can only continue with another project where most of the commits (and preferable all the commits) have been done by s.leduc.

We do not give a new Drupal role to the maintainer, but to the account used to commit the code. In fact, these applications are not per projects, but per accounts. We do not change the project status, but the account status by giving a new role.

I am changing priority as per Issue priorities → .

This thread has been idle, in the Needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, and I marked it as Closed (won't fix).

If this is incorrect, and you are still pursuing this application, then please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.