"Invalid user specified." occurs for auto-complete user field if you don't select suggested username

As you can see above, pasting code as text does not work.

Reverting part of acl.admin.inc of v1.1.0 to v1.0.0-beta1 works OK.

Such version number have never existed.

Please provide a patch against the current -dev version.

Thank you for reply, and sorry for typo.
wrong: v1.1.0 to v1.0.0-beta1
correct: 8.x-1.1 to 8.x-1.0-beta1

And here is a patch against 8.x-1.x-dev (dev-1.x 963031f).

best regards,

Never mind the D9.5 — it's the code for 8 and 9. The test bot says

fatal: corrupt patch at line 31

By now we have a 2.x branch for D10, and the patch needs to go against 2.x-dev now. The D8 and D10 branches haven't diverged much yet, the code that you're concerned with is probably still the same.

I checked the issue and I think we should just let `EntityAutocomplete::validateEntityAutocomplete` validate this element, instead of trying to validate it ourselves, it will validate and set errors like normal entity_autocomplete form element.
I've tested it as much as I could but I would be good if somebody with live usage of acl_edit_form could test it as well.
I have prepared patch which implement it, so please take a look.

Hi, thank you for the patch. Unfortunately the patch doesn't work well for me.
Steps to reproduce
1. Copy a username from other web page or txt file, and paste it to the user field.
2. Suggested username appears under the auto-complete user field, but ignore it, and hit the [Add user] button.
3. The username isn't added in "Current users" list without "Invalid user specified." error message.

best regards,

@kubokura are you sure you applying the patch correctly? "Invalid user specified" error message is removed and all errors are handled with EntityAutocomplete::validateEntityAutocomplete and they are different.
What version of the module are you using?

Hi, @ad0z, I'm sorry. I applied the patch against acl 8.x-1.1 on Drupal 9.5.11.
Please disregard my comment of Oct 25.
I still can't upgrade to D10 due to composer error, so I can't apply the patch correctly at this moment.

@kubokura I've prepared patch for 8.x-1.1, attaching below.

Hi, @ad0z, thank you for the new patch.
The same symptom "The username isn't added in "Current users" list without "Invalid user specified." error message." occurs, so I modified your patch a little, and it works for me.
+ $uid = $form_state->getValue([$acl_wrapper_key, 'add']);
-> + $uid = $form_state->getValue([$acl_wrapper_key, 'view', 'add']);

@kubokura thanks for finding it, my patch didn't support nested form elements, and I think your patch need update as it hard code element machine name to be 'view'.
I am attaching patch to 8.x-1.x and 2.x, could you test one for 8.x-1.x?

Hi, @ad0z, thank you for the update. acl-validate-changes-3389445-19.patch works for me. Username is entered successfully without selecting suggested username.