Fix failing tests and code style issues

Interesting! Now we have a different failure using the gitlab pipeline.

Somewhere, the tests for unsupported confirmation types were commented in again. See #3314878: Module currently only works with Confirmation type "Page" and "Inline" → .

All done, please review!

@Grevil failed pipeline?

Yea, he doesn't seem to require the "webform" dependency properly... For some reason, this now also gets thrown on the main branch....
Maybe we need to specify testing dependencies now with gitlab ci?

Code LGTM btw!

@Grevil: Perhaps we need webform:webform_ui as test dependency? Do the tests use the UI? If yes, that's the reason. For production the UI isn't required.

Once the tests go green, please merge this and tag a new release.

Sry - prepopulated select

No, we are not using the "webform_ui". I'll add the test_dependencies.

@Grevil: Commented

Ok I think our code is fine, the real reason might be that webform has no stable Drupal 10 release, which breaks the dependencies. So let's merge this and add an issue to remember this reason. 95% sure.

Aight, I'll create a follow-up issue!

Automatically closed - issue fixed for 2 weeks with no activity.