- Issue created by @charles belov
- 🇮🇳India abhisekmazumdar India
I can confirm that the said issue exists and applying the patch is skipped.
https://git.drupalcode.org/issue/drupal-3273986/-/commit/7bd5d37bb6926152fd9cca21cc565824e6b034f2 (STM patch 7bd5d37bb6926152fd9cca21cc565824e6b034f2) Could not apply patch! Skipping. The error was: Cannot apply patch https://git.drupalcode.org/issue/drupal-3273986/-/commit/7bd5d37bb6926152fd9cca21cc565824e6b034f2
A high-level analysis from my side:
I assume while creating a new site the
cweagans/composer-patches
has a default value forcomposer-exit-on-patch-failure
as false. We will need to addcomposer-exit-on-patch-failure
as true to the composer.json for the newly created site.
https://github.com/cweagans/composer-patches/tree/1.7.3?tab=readme-ov-fi... - 🇮🇳India abhisekmazumdar India
I gave some more thinking to it and believe it's acceptable to skip and proceed with the site installation process. We have already virtually created the site, and at this point(composer is installing the dependency.).
However, I agree that the skipped patch error should be emphasized more. I'm unsure if it's possible or if the project maintainers are open to achieving this.