CKEditor 5's Functional JS tests take a long time to run

time ../vendor/bin/phpunit modules/ckeditor5/tests/src/FunctionalJavascript/ImageTest.php

real	9m58.387s
user	3m20.882s
sys	0m38.975s

Yep, functional JS tests are slow.

There's a lot of waiting for things to happen.

The only proposal I have is a very simple one, somewhat reminiscent of 📌 Add GenericModuleTestBase and use it to test general module things Downport : require all functional JS tests (in core at least) to have only a single test method. That way, they can be maximally parallellized.

I think we need to figure out if we want to do 📌 [experiment] Explore paratest to run our phpunit tests in parallel Needs work since that runs by-method I think. If we don't, then we should do one-test-method-per-class for the very slowest tests per #3.

Sounds like a plan!

Had a look at paratest, running by method will take a lotof refactoring and it also supports running by class, so even if we were to replace run-tests.sh with it we might not switch to per-method.

I think we should go ahead here, even if we switch to per-method concurrency eventually, it won't do any harm, it'll be just slightly unnecessary work.

I don't think we need to split these into method-per-class, a test class with 10-12 methods each or whatever logical split makes sense should be enough for now - i.e. splitting in two is ~half the overall test time and that might be enough at least to start with.

THe breakup seems fine. Naming seems good too.

lauriii → closed merge request !4874

Committed c669e40 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.