- Status changed to Postponed: needs info
about 1 year ago 10:49am 22 September 2023 - ๐ฉ๐ชGermany Anybody Porta Westfalica
@liuyuanchao thanks! Could you perhaps provide screenshots of the steps to reproduce this? It's not yet totally clear to me, when that happens.
We should also check, if the issue also exists in 5.x
- Status changed to Closed: won't fix
about 1 year ago 11:56am 11 October 2023 - ๐ฉ๐ชGermany Anybody Porta Westfalica
No reply and I don't think we will support that. Feel free to reopen with a MR to review otherwise.
Please try 5.x before.
- ๐บ๐ธUnited States TolstoyDotCom L.A.
You can duplicate this by creating a node type with a reference to media entities. Then, create a node of that type and add images. Photoswipe should work OK. Then, edit the node and add a video. You'll get the crash above.
In my case,
$this->settings['photoswipe_reference_image_field']
in ImageDTO's constructor isfield_media_image
, but$this->getMediaSourceField($media)
isfield_media_video_file
for the video. Thus,$media->get($photoswipe_reference_image_field);
crashes.It's easier for me to just add a separate video field to my node type, but you might want to skip media types that you aren't expecting.
- ๐บ๐ธUnited States TolstoyDotCom L.A.
Feel free to close if you still don't want to resolve this.