[1.0.x] eca_commerce

I ran through this checklist: https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

Please fix the below PHPCS issue:

FILE: /eca_commerce/src/Plugin/Action/ChangePriceInCartAction.php
------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------
 63 | WARNING | #description values usually have to run through t() for translation
------------------------------------------------------------------------------------------------------

I've fixed that, thanks.

Any chance you can you let me know what version of phpcs you're using? My version didn't show that warning.

I'm using:

./vendor/bin/phpcs \
  --standard="Drupal,DrupalPractice" -n \
  --extensions="php,module,inc,install,test,profile,theme" \
  web/modules/contrib/eca_commerce

It is the drupal/coder version that is relevant, as it is drupal/coder which contains the Drupal and DrupalPractice rulesets.

I'm running 8.3 which is the latest. I fixed the issue anyway since it was a good suggestion I was just curious.

Is there anything else I need to do here, or is it just waiting in the queue for review?

There are commits signed as nlighteneddesign, which does not link to any drupal.org account. Who has done those commits?

Those are me, my company is nlighteneddesign. It's not a shared account I'm a solo freelancer.

Thanks

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries → ' post on Responsible maintainers
• Best practices for creating and maintaining projects →
• Maintaining a drupal.org project with Git →
• Commit messages - providing history and credit →
• Release naming conventions → .
• Helping maintainers in the issue queues →

You can find more contributors chatting on the Slack → #contribute channel. So, come hang out and stay involved → .
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.

I thank all the reviewers.

Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.