Media method incorrect return types

Created on 18 September 2023, over 1 year ago

The declared returns types of getThumbnailWidth and getThumbnailHeight inside of \Drupal\media\Entity\Media are not respected.

For instance, both methods rely on getMetadata, but it's return signature does not match the one of the calling methods.

Enforce the declared return types, either int or null.

Open a PR.

🐛 Bug report

Status

Needs work

Version

10.1 ✨

Component

Media →

Last updated about 15 hours ago

Created by

🇸🇮Slovenia alecsmrekar

Live updates comments and jobs are added and updated live.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Comments & Activities

Issue created by @alecsmrekar
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,479 pass
@alecsmrekar opened merge request.
Status changed to Needs review over 1 year ago1:11pm 18 September 2023
Comment over 1 year ago →
🇸🇮Slovenia alecsmrekar
Status changed to Needs work over 1 year ago2:14pm 18 September 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
Thank you for reporting.

Could we get a test case to show the bug please.

Production build 0.71.5 2024