- Issue created by @saschaeggi
- ๐ช๐ธSpain ckrina Barcelona
Just added ๐ฑ Define logo origin on the Toolbar Active to previously define where this logo should come from.
The problem with SVG is that if we let users upload SVG files it might be a security problem (see #2868079: Sanitize OR add Content-Security-Policy for SVGs โ ) so I'd go with the proposed solution of increasing the resolution (forcing the 32px size anyway).
- ๐ฎ๐ณIndia chetan 11
chetan 11 โ made their first commit to this issueโs fork.
- @chetan-11 opened merge request.
- Status changed to Needs work
over 1 year ago 10:53am 18 September 2023 - ๐ช๐ธSpain ckrina Barcelona
Hi @chetan 11, thanks for working on this!
You should keep the inverted version of the logo with the blue background and white shape respecting the existing designs.
- ๐ฎ๐ณIndia chetan 11
Hey @ckrina
I have update the logo according to the design, please check the raised PR. - ๐จ๐ญSwitzerland saschaeggi Zurich
This still needs work:
- The filename is incorrect, the file should be called
logo.png
- There are unnecessary CSS changes
- The filename is incorrect, the file should be called
- ๐ช๐ธSpain ckrina Barcelona
Hey @chetan 11, thanks for the work.
A few more things:
- You just need to replace the existing logo, no need to keep the old one.
- The PNG used is not transparent and has white borders around it, specially on the laterals. You can use Figma to export the logo in there as PNG and with transparency.
- First commit to issue fork.
- Status changed to Needs review
about 1 year ago 7:10am 2 November 2023 - ๐ท๐บRussia kostyashupenko Omsk
Replaced default png by vector logo (copied from figma and optimized through the adobe illustrator)
- ๐ช๐ธSpain ckrina Barcelona
Moving to NW because the folder for the logo shouldn't be
icons
, it should stay asimages
. - Status changed to Needs work
about 1 year ago 4:28pm 9 November 2023 - Status changed to Needs review
about 1 year ago 5:17am 10 November 2023 - Status changed to Fixed
about 1 year ago 9:28am 10 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.