- Issue created by @tim-diels
- 🇩🇪Germany Grevil
I think there was no reason for the original string casting, as I don't see a world, where "body_value" will not be a string. We can remove that again, but I don't think it matters much.
With rebasing a patch, I saw a change in src/GlossifyBase.php on line 155
- $tip = $this->sanitizeTip($term->tip, $tooltip_truncate);
+ $tip = $this->sanitizeTip((string) $term->tip, $tooltip_truncate);
I do however see this part of code exists further down in the class and has not been changed.
Should the code also be changed? I saw no discussion about the change except a reference from
📌
Automated Drupal 10 compatibility fixes for Glossify
Fixed
with the commit https://git.drupalcode.org/project/glossify/-/merge_requests/11/diffs?co...
https://git.drupalcode.org/project/glossify/-/blob/3.x/src/GlossifyBase....
Update the code.
Discuss if the change is needed and update the code.
-
-
-
Active
3.0
Code
I think there was no reason for the original string casting, as I don't see a world, where "body_value" will not be a string. We can remove that again, but I don't think it matters much.